Merge lp:~cjwatson/launchpad-buildd/livefs-remove-suite-compat into lp:launchpad-buildd

Proposed by Colin Watson
Status: Merged
Approved by: William Grant
Approved revision: 122
Merged at revision: 122
Proposed branch: lp:~cjwatson/launchpad-buildd/livefs-remove-suite-compat
Merge into: lp:launchpad-buildd
Diff against target: 38 lines (+4/-13)
2 files modified
debian/changelog (+2/-0)
lpbuildd/livefs.py (+2/-13)
To merge this branch: bzr merge lp:~cjwatson/launchpad-buildd/livefs-remove-suite-compat
Reviewer Review Type Date Requested Status
William Grant code Approve
Review via email: mp+224802@code.launchpad.net

Commit message

Stop accepting the "suite" argument to livefs builds, now that Launchpad has been updated to use the newer series/pocket protocol.

Description of the change

Now that launchpad-buildd 123 has been deployed everywhere (including staging), and Launchpad has been updated to use the new series/pocket protocol for livefs builds, we can drop the old suite protocol.

To post a comment you must log in.
Revision history for this message
William Grant (wgrant) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2014-06-25 01:55:57 +0000
3+++ debian/changelog 2014-06-27 12:21:54 +0000
4@@ -14,6 +14,8 @@
5 [ Colin Watson ]
6 * Install ltsp-server (but not its Recommends) for i386 livefs builds, as
7 Edubuntu needs it.
8+ * Stop accepting the "suite" argument to livefs builds, now that Launchpad
9+ has been updated to use the newer series/pocket protocol.
10
11 -- Colin Watson <cjwatson@ubuntu.com> Tue, 24 Jun 2014 14:58:16 +0100
12
13
14=== modified file 'lpbuildd/livefs.py'
15--- lpbuildd/livefs.py 2014-06-15 23:40:27 +0000
16+++ lpbuildd/livefs.py 2014-06-27 12:21:54 +0000
17@@ -42,19 +42,8 @@
18 self.subarch = extra_args.get("subarch")
19 self.project = extra_args["project"]
20 self.subproject = extra_args.get("subproject")
21- if "series" in extra_args:
22- self.series = extra_args["series"]
23- self.pocket = extra_args["pocket"]
24- else:
25- # For compatibility; remove once launchpad-buildd 123 is
26- # deployed in production and the Launchpad master has been
27- # adjusted to pass series and pocket rather than suite.
28- suite = extra_args["suite"]
29- if "-" in suite:
30- self.series, self.pocket = suite.rsplit("-", 1)
31- else:
32- self.series = suite
33- self.pocket = "release"
34+ self.series = extra_args["series"]
35+ self.pocket = extra_args["pocket"]
36 self.datestamp = extra_args.get("datestamp")
37 self.image_format = extra_args.get("image_format")
38 self.locale = extra_args.get("locale")

Subscribers

People subscribed via source and target branches

to all changes: