Code review comment for lp:~cjwatson/charms/trusty/ubuntu-repository-cache/signed-is-metadata

Revision history for this message
Pen Gale (pengale) wrote :

This currently fails two tests when I run bundletester against my local lxd envronment. "make lint" fails, and 110-multi_unit.simple fails.

Tracebacks here: http://paste.ubuntu.com/18176623/

The linter is probably a simple fix: you need to reference the version of flake8 in your venv in your Makefile (.venv/bin/flake8) rather than the system version, as the Makefile currently does.

I'm not 100% certain what is happening with the other traceback. It might be a timing issue. If you can't reproduce it locally, ping me in the comments here (or on freenode#juju -- my handle is "petevg"), and I will dig into it further.

review: Needs Fixing

« Back to merge proposal