Merge lp:~cjwatson/charms/trusty/ubuntu-repository-cache/signed-is-metadata into lp:charms/trusty/ubuntu-repository-cache

[Colin Watson]

Handle dists/*/*/signed the same way as dists/*/*/uefi.

Handle dists/*/*/signed the same way as dists/*/*/uefi.

This may have been part of the cause of the problems seen in https://bugs.launchpad.net/launchpad/+bug/1585853 (though by no means the sole cause).

[Dan Watkins (oddbloke)]

14:34:43 Odd_Bloke | cjwatson: How will existing deployments be affected by that ubuntu-repository-cache change?
14:37:06 cjwatson | Odd_Bloke: All it does is sync that directory later in the process, with pool and the other stuff that's transferred in bulk. No migration issues.

[Review Queue (review-queue)]

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-aws/4426/

review: Needs Fixing (automated testing)

[Review Queue (review-queue)]

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-lxc/4406/

review: Needs Fixing (automated testing)

[Pen Gale (pengale)]

This currently fails two tests when I run bundletester against my local lxd envronment. "make lint" fails, and 110-multi_unit.simple fails.

Tracebacks here: http://paste.ubuntu.com/18176623/

The linter is probably a simple fix: you need to reference the version of flake8 in your venv in your Makefile (.venv/bin/flake8) rather than the system version, as the Makefile currently does.

I'm not 100% certain what is happening with the other traceback. It might be a timing issue. If you can't reproduce it locally, ping me in the comments here (or on freenode#juju -- my handle is "petevg"), and I will dig into it further.

review: Needs Fixing

[Charles Butler (lazypower)]

Greetings Colin,

Thank you for your submission against the ubuntu-repository-cache charm! I've taken some time to look into this, and have some concerns that will need to be addressed before this branch can be merged.

The first is it appears that the ubuntu-repository-cache upstream has actually moved from the requested branch to lp:~cloudware/charms/trusty/ubuntu-repository-cache/trunk. That leaves this merge proposal orphaned and will need to resubmit against the proper branch.

If you have any questions/comments/concerns about the review contact us in #juju on irc.freenode.net or email the mailing list <email address hidden>, or ask a question tagged with "juju" on http://askubuntu.com.

review: Needs Resubmitting

Unmerged revisions

212. By Colin Watson on 2016-05-26

Handle dists/*/*/signed the same way as dists/*/*/uefi.

=== modified file 'lib/ubuntu_repository_cache/mirror.py'
--- lib/ubuntu_repository_cache/mirror.py	2015-09-28 20:43:45 +0000
+++ lib/ubuntu_repository_cache/mirror.py	2016-05-26 12:07:20 +0000
@@ -85,6 +85,7 @@
                      '--exclude=dists/*/*/debian-installer',
                      '--exclude=dists/*/*/dist-upgrader-all',
                      '--exclude=dists/*/*/installer*',
+                     '--exclude=dists/*/*/signed',
                      '--exclude=dists/*/*/uefi',
                      )
     host.rsync(rsync_source,