Code review comment for lp:~cjohnston/uci-engine/webui-apache-vhost-staging

Revision history for this message
Chris Johnston (cjohnston) wrote :

> >Django is expecting a host header matching the allowed_hosts setting, which
> the ProxyPreserveHosts option to Apache provides. In situations without real
> DNS names, as in development, this will break things unless allowed_hosts has
> the IP of the Apache unit in it.
>
> Does this mean we can only have things work in staging or have things work in
> production? I/S uses the deploy.py script to build things and then add their
> special sauce. It feels like we should provide a file that works in
> development, and they could update this file when generating their special
> sauce to make this work in production?

I am going to add the Apache instance info to allowed_hosts so that it works in dev.

« Back to merge proposal