Merge lp:~cjohnston/uci-engine/webui-apache-vhost-staging into lp:uci-engine

[Chris Johnston]

Fix 500 error for TS urls in staging.

Currently in staging we are still seeing a 500 error when trying to access the TS urls.. This fixes the issue for staging per IS' suggestions, however, development is broken with this and will come in a separate MP.

[David Lawson (deej)]

Django is expecting a host header matching the allowed_hosts setting, which the ProxyPreserveHosts option to Apache provides. In situations without real DNS names, as in development, this will break things unless allowed_hosts has the IP of the Apache unit in it.

As far as swapping out mod_rewrite for mod_proxy, mod_proxy more nearly accomplishes what you appear to be trying to do, mapping URL space on the local server to a URL space on a remote server. ProxyPass and/or ProxyPassMatch is generally the way to go about this, ProxyPassReverse only applies to rewrites passed back from the server you're proxying to, so it wont accomplish much, if anything, without a matching ProxyPass stanza. The proxy module is also, frankly, much simpler to use.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:559
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/839/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/839/rebuild

review: Approve (continuous-integration)

[Andy Doan (doanac)]

Comment inline.

>Django is expecting a host header matching the allowed_hosts setting, which the ProxyPreserveHosts option to Apache provides. In situations without real DNS names, as in development, this will break things unless allowed_hosts has the IP of the Apache unit in it.

Does this mean we can only have things work in staging or have things work in production? I/S uses the deploy.py script to build things and then add their special sauce. It feels like we should provide a file that works in development, and they could update this file when generating their special sauce to make this work in production?

[Chris Johnston (cjohnston)]

> >Django is expecting a host header matching the allowed_hosts setting, which
> the ProxyPreserveHosts option to Apache provides. In situations without real
> DNS names, as in development, this will break things unless allowed_hosts has
> the IP of the Apache unit in it.
>
> Does this mean we can only have things work in staging or have things work in
> production? I/S uses the deploy.py script to build things and then add their
> special sauce. It feels like we should provide a file that works in
> development, and they could update this file when generating their special
> sauce to make this work in production?

I am going to add the Apache instance info to allowed_hosts so that it works in dev.

[David Lawson (deej)]

Yeah, if there's an addition to the Django settings file to set the IP of the Apache unit in allowed_hosts it'll work in dev as well.

[lp:~cjohnston/uci-engine/webui-apache-vhost-staging]

560. By Chris Johnston on 2014-06-13

Move apache include to before Proxy stuff per review

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:560
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/861/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/861/rebuild

review: Approve (continuous-integration)

[Evan (ev)]

Thanks for sorting out that remaining issue, Chris. This looks good.

review: Approve

Unmerged revisions

560. By Chris Johnston on 2014-06-13

Move apache include to before Proxy stuff per review

559. By Chris Johnston on 2014-06-11

Update webui apache vhost to work properly for staging

=== modified file 'juju-deployer/configs/webui_http_vhost'
--- juju-deployer/configs/webui_http_vhost	2014-06-09 16:30:51 +0000
+++ juju-deployer/configs/webui_http_vhost	2014-06-13 13:10:09 +0000
@@ -27,11 +27,11 @@
      Allow from all
   </Directory>
 
-  RewriteEngine on
   Include /etc/apache2/juju-*.conf
-  RewriteRule ^/api/(.*)$ http://{{ ciairlinetsdjango }}/api/$1 [P]
-  RewriteRule ^/gk/api/(.*)$ http://{{ ciairlinegatekeeperrestish }}/api/$1 [P]
-  RewriteCond %{REQUEST_URI} !^/static/
-  RewriteRule ^/(.*)$ http://{{ ciairlinewebuidjango }}/$1 [P]
-  ProxyPassReverse / http://{{ ciairlinetsdjango }}/
+
+  ProxyPreserveHost On
+  ProxyPass /api/ http://{{ ciairlinetsdjango }}/api/
+  ProxyPass /gk/api/ http://{{ ciairlinegatekeeperrestish }}/api/
+  ProxyPass /static/ !
+  ProxyPass / http://{{ ciairlinewebuidjango }}/
 </VirtualHost>