Code review comment for lp:~cjohnston/ubuntu-ci-services-itself/goldenpackages

Revision history for this message
Francis Ginther (fginther) wrote :

I think I understand how BinaryPackage is going to be used. The golden set of packages == all the BinaryPackage objects. +1

How does this handle a ticket that requests adding or removing a package, but the ticket ultimately fails. For example:

1) The golden package list is [A, B, C].
2) A ticket is created which includes a request to add package [D, E] and remove [A].
3) An image is built and tested with [B, C, D, E].
4) The test and ticket fails.
5) The golden package set remains [A, B, C].

I'm not seeing how the ticket holds the binary package information (but perhaps that's for a different MP).

review: Needs Information

« Back to merge proposal