Merge lp:~cjohnston/ubuntu-ci-services-itself/goldenpackages into lp:ubuntu-ci-services-itself

[Chris Johnston]

Change from seeded binaries to tested sources

[lp:~cjohnston/ubuntu-ci-services-itself/goldenpackages]

54. By Chris Johnston on 2013-12-19

[r=Ursula Junque] Change out the people app for an email field from Chris Johnston

55. By Chris Johnston on 2013-12-19

Remove seeded packages

[Francis Ginther (fginther)]

I think I understand how BinaryPackage is going to be used. The golden set of packages == all the BinaryPackage objects. +1

How does this handle a ticket that requests adding or removing a package, but the ticket ultimately fails. For example:

1) The golden package list is [A, B, C].
2) A ticket is created which includes a request to add package [D, E] and remove [A].
3) An image is built and tested with [B, C, D, E].
4) The test and ticket fails.
5) The golden package set remains [A, B, C].

I'm not seeing how the ticket holds the binary package information (but perhaps that's for a different MP).

review: Needs Information

[Francis Ginther (fginther)]

> I think I understand how BinaryPackage is going to be used. The golden set of
> packages == all the BinaryPackage objects. +1
>
> How does this handle a ticket that requests adding or removing a package, but
> the ticket ultimately fails. For example:
>
> 1) The golden package list is [A, B, C].
> 2) A ticket is created which includes a request to add package [D, E] and
> remove [A].
> 3) An image is built and tested with [B, C, D, E].
> 4) The test and ticket fails.
> 5) The golden package set remains [A, B, C].
>
> I'm not seeing how the ticket holds the binary package information (but
> perhaps that's for a different MP).

Found the added_binaries and removed_binaries in the trunk.

Approve

review: Approve

=== modified file 'ticket_system/project/migrations/0001_initial.py'
--- ticket_system/project/migrations/0001_initial.py	2013-12-09 19:35:22 +0000
+++ ticket_system/project/migrations/0001_initial.py	2013-12-19 17:25:55 +0000
@@ -20,7 +20,6 @@
             (u'id', self.gf('django.db.models.fields.AutoField')(primary_key=True)),
             ('name', self.gf('django.db.models.fields.CharField')(max_length=4096)),
             ('sourcepackage', self.gf('django.db.models.fields.related.ForeignKey')(to=orm['project.SourcePackage'])),
-            ('seeded', self.gf('django.db.models.fields.BooleanField')(default=False)),
         ))
         db.send_create_signal(u'project', ['BinaryPackage'])
 
@@ -38,7 +37,6 @@
             'Meta': {'object_name': 'BinaryPackage', 'db_table': "'binarypackage'"},
             u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
             'name': ('django.db.models.fields.CharField', [], {'max_length': '4096'}),
-            'seeded': ('django.db.models.fields.BooleanField', [], {'default': 'False'}),
             'sourcepackage': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['project.SourcePackage']"})
         },
         u'project.sourcepackage': {

=== modified file 'ticket_system/project/models.py'
--- ticket_system/project/models.py	2013-12-09 19:35:22 +0000
+++ ticket_system/project/models.py	2013-12-19 17:25:55 +0000
@@ -32,7 +32,6 @@
 
     name = models.CharField(max_length=4096)
     sourcepackage = models.ForeignKey("SourcePackage")
-    seeded = models.BooleanField(default=False)
 
     def __unicode__(self):
         return self.name

=== modified file 'ticket_system/project/tests.py'
--- ticket_system/project/tests.py	2013-12-16 18:52:37 +0000
+++ ticket_system/project/tests.py	2013-12-19 17:25:55 +0000
@@ -122,7 +122,6 @@
         self.assertEqual(obj['objects'][0], {
             u'id': self.binarypackage.pk,
             u'name': unicode(self.binarypackage.name),
-            u'seeded': self.binarypackage.seeded,
             u'sourcepackage': {
                 u'id': self.sourcepackage.pk,
                 u'name': unicode(self.sourcepackage.name),
@@ -136,8 +135,7 @@
         obj = self.getResource(self.detail_url)
 
         # We use ``assertKeys`` here to just verify the keys, not all the data.
-        self.assertKeys(obj, ['id', 'name', 'resource_uri', 'seeded',
-                        'sourcepackage'])
+        self.assertKeys(obj, ['id', 'name', 'resource_uri', 'sourcepackage'])
         self.assertEqual(obj['name'], self.binarypackage.name)
 
     def test_post_binarypackage(self):