Merge lp:~cjohnston/summit/sponsorship-form-follow-guidelines into lp:summit

Proposed by Chris Johnston
Status: Merged
Approved by: Chris Johnston
Approved revision: 431
Merged at revision: 432
Proposed branch: lp:~cjohnston/summit/sponsorship-form-follow-guidelines
Merge into: lp:summit
Diff against target: 111 lines (+18/-28)
3 files modified
summit/sponsor/forms.py (+5/-4)
summit/sponsor/templates/sponsor/step0.html (+7/-15)
summit/sponsor/templates/sponsor/step1.html (+6/-9)
To merge this branch: bzr merge lp:~cjohnston/summit/sponsorship-form-follow-guidelines
Reviewer Review Type Date Requested Status
Chris Johnston Approve
Review via email: mp+118830@code.launchpad.net

Commit message

Updates request sponsorship form to follow guidelines.

To post a comment you must log in.
Revision history for this message
Chris Johnston (cjohnston) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'summit/sponsor/forms.py'
--- summit/sponsor/forms.py 2012-01-23 01:18:55 +0000
+++ summit/sponsor/forms.py 2012-08-08 21:19:18 +0000
@@ -25,6 +25,7 @@
2525
26from summit.extra.formsets import WizardFormSet26from summit.extra.formsets import WizardFormSet
27from summit.extra.fields import CountryField27from summit.extra.fields import CountryField
28from common.forms import RenderableMixin
2829
29from summit.sponsor.models import (Sponsorship, SponsorshipSuggestion,30from summit.sponsor.models import (Sponsorship, SponsorshipSuggestion,
30 SponsorshipScore, NonLaunchpadSponsorship)31 SponsorshipScore, NonLaunchpadSponsorship)
@@ -74,10 +75,10 @@
74http://creativecommons.org/licenses/by-sa/3.0/''')75http://creativecommons.org/licenses/by-sa/3.0/''')
7576
7677
77class SponsorshipForm1(forms.Form):78class SponsorshipForm1(forms.Form, RenderableMixin):
78 location = forms.CharField(max_length=50,79 location = forms.CharField(max_length=50, label="Closest airport",
79 help_text='Enter your nearest city or airport')80 help_text='Enter your nearest city or airport')
80 country = CountryField()81 country = CountryField(label="Country")
81 about = forms.CharField(max_length=3000,82 about = forms.CharField(max_length=3000,
82 label='About yourself',83 label='About yourself',
83 help_text='Tell us about yourself and your work within the Ubuntu community',84 help_text='Tell us about yourself and your work within the Ubuntu community',
@@ -142,7 +143,7 @@
142 return mark_safe(u'\n'.join([unicode(self.management_form), forms]))143 return mark_safe(u'\n'.join([unicode(self.management_form), forms]))
143144
144145
145class SponsorshipForm3(forms.Form):146class SponsorshipForm3(forms.Form, RenderableMixin):
146 needs_travel = forms.BooleanField(label='Sponsorship of Travel:',147 needs_travel = forms.BooleanField(label='Sponsorship of Travel:',
147 required=False,148 required=False,
148 initial=True)149 initial=True)
149150
=== modified file 'summit/sponsor/templates/sponsor/step0.html'
--- summit/sponsor/templates/sponsor/step0.html 2012-07-31 00:22:01 +0000
+++ summit/sponsor/templates/sponsor/step0.html 2012-08-08 21:19:18 +0000
@@ -15,29 +15,21 @@
15 <article class="span-8">15 <article class="span-8">
16 <h1>Request Sponsorship</h1>16 <h1>Request Sponsorship</h1>
17 <p>17 <p>
18 To request sponsorship we need to get a few details from you, such as where you'll be travelling from. We also need to know a bit about you so that we can judge your request. We'll get some of that from Launchpad, but please take the time to tell us about yourself in your own words.18 To request sponsorship for {{ summit.title }} in {{ summit.location }} we need to get a few details from you, such as where you'll be travelling from. We also need to know a bit about you so that we can judge your request. We'll get some of that from Launchpad, but please take the time to tell us about yourself in your own words.
19 </p>
20
21 <p>
22 If you have any problems with Summit, please <a href="https://bugs.launchpad.net/summit/+filebug">file a bug</a>.
23 </p>19 </p>
24 </article>20 </article>
25 </div>21 </div>
2622
27 <div class="row">23 <div class="row">
28 <article class="span-8">24 <article id="form" class="span-8">
29 <form method="post">25 <form method="post">{% csrf_token %}
30 {% csrf_token %}26 <fieldset>
31 <table>27 <h3>Your details</h3>
32 <tr><th>Summit:</th><td><span>{{ summit.name }}<br/>{{ summit.location }}</span></td></tr>28 {{ form.as_template }}
33 <tr><td colspan="2"><h2>Your details</h2></td></tr>
34 <tr><th>Your name:</th><td><span>{{ user.get_full_name }}</span></td></tr>
35 <tr><th>E-mail address:</th><td><span>{{ user.email }}</span></td></tr>
36 {{ form }}
37 </table>
38 <input type="hidden" name="{{ step_field }}" value="{{ step0 }}" />29 <input type="hidden" name="{{ step_field }}" value="{{ step0 }}" />
39 {{ previous_fields|safe }}30 {{ previous_fields|safe }}
40 <input type="submit" value="Next"/>31 <input type="submit" value="Next"/>
32 </fieldset>
41 </form>33 </form>
42 </article>34 </article>
43 </div>35 </div>
4436
=== modified file 'summit/sponsor/templates/sponsor/step1.html'
--- summit/sponsor/templates/sponsor/step1.html 2012-07-31 00:22:01 +0000
+++ summit/sponsor/templates/sponsor/step1.html 2012-08-08 21:19:18 +0000
@@ -13,9 +13,6 @@
13<div class="row">13<div class="row">
14<article class="span-8">14<article class="span-8">
15<h1>Request Sponsorship</h1>15<h1>Request Sponsorship</h1>
16
17<br />
18<h2>Further information</h2>
19<p>16<p>
20Almost done, there's just a few final details we need for your application;17Almost done, there's just a few final details we need for your application;
21and you've a chance to add anything else that you think is important when18and you've a chance to add anything else that you think is important when
@@ -25,15 +22,15 @@
25</div>22</div>
2623
27<div class="row">24<div class="row">
28<article class="span-8">25<article id="form" class="span-8">
29<form method="post">26<form method="post">{% csrf_token %}
30{% csrf_token %}27<fieldset>
31<table>28<h3>Further information</h3>
32{{ form }}29{{ form.as_template }}
33</table>
34<input type="hidden" name="{{ step_field }}" value="{{ step0 }}" />30<input type="hidden" name="{{ step_field }}" value="{{ step0 }}" />
35{{ previous_fields|safe }}31{{ previous_fields|safe }}
36<input type="submit" value="Finish"/>32<input type="submit" value="Finish"/>
33</fieldset>
37</form>34</form>
38</article>35</article>
39</div>36</div>

Subscribers

People subscribed via source and target branches