Merge lp:~cjohnston/summit/private into lp:summit

Proposed by Chris Johnston
Status: Merged
Approved by: Michael Hall
Approved revision: 110
Merged at revision: 131
Proposed branch: lp:~cjohnston/summit/private
Merge into: lp:summit
Diff against target: 46 lines (+9/-1)
3 files modified
.bzrignore (+6/-0)
summit/schedule/models/roommodel.py (+1/-0)
summit/schedule/models/summitmodel.py (+2/-1)
To merge this branch: bzr merge lp:~cjohnston/summit/private
Reviewer Review Type Date Requested Status
Michael Hall (community) Approve
Review via email: mp+68183@code.launchpad.net

Commit message

Adds private room as an option for a room status.

To post a comment you must log in.
Revision history for this message
Michael Hall (mhall119) wrote :

Doesn't fully resolve the bug, but it's the first step in the process. More work will be needed to determine how to properly allow viewing and scheduling.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file '.bzrignore'
--- .bzrignore 2011-04-20 14:26:23 +0000
+++ .bzrignore 2011-07-17 18:32:48 +0000
@@ -4,3 +4,9 @@
4summit/summit.db4summit/summit.db
5summit/ubuntu_website5summit/ubuntu_website
6summit/linaro_website6summit/linaro_website
7summit/docs
8summit/south
9summit/.hgignore
10summit/.hg_archival.txt
11summit/.hgtags
12summit/setup.py
713
=== modified file 'summit/schedule/models/roommodel.py'
--- summit/schedule/models/roommodel.py 2010-03-05 10:33:36 +0000
+++ summit/schedule/models/roommodel.py 2011-07-17 18:32:48 +0000
@@ -33,6 +33,7 @@
33 (u'open', u'Openly scheduled'),33 (u'open', u'Openly scheduled'),
34 (u'plenary', u'Plenary events'),34 (u'plenary', u'Plenary events'),
35 (u'closed', u'Closed'),35 (u'closed', u'Closed'),
36 (u'private', u'Private'),
36 )37 )
3738
38 summit = models.ForeignKey(Summit)39 summit = models.ForeignKey(Summit)
3940
=== modified file 'summit/schedule/models/summitmodel.py'
--- summit/schedule/models/summitmodel.py 2011-06-12 02:00:30 +0000
+++ summit/schedule/models/summitmodel.py 2011-07-17 18:32:48 +0000
@@ -28,6 +28,7 @@
2828
29from django.core.exceptions import ObjectDoesNotExist29from django.core.exceptions import ObjectDoesNotExist
30from django.db import models30from django.db import models
31from django.db.models.query_utils import Q
3132
32from django.contrib.auth.models import User33from django.contrib.auth.models import User
3334
@@ -138,7 +139,7 @@
138 else:139 else:
139 return cmp(a.track.title, b.track.title)140 return cmp(a.track.title, b.track.title)
140141
141 rooms = self.room_set.exclude(type__exact='closed')142 rooms = self.room_set.exclude(Q(type__exact='closed') | Q(type__exact='private'))
142 return sorted(rooms, cmp=by_title)143 return sorted(rooms, cmp=by_title)
143144
144 def open_rooms(self):145 def open_rooms(self):

Subscribers

People subscribed via source and target branches