Merge lp:~cjohnston/summit/ga-templatetag into lp:summit

Proposed by Chris Johnston
Status: Merged
Approved by: Michael Hall
Approved revision: 490
Merged at revision: 487
Proposed branch: lp:~cjohnston/summit/ga-templatetag
Merge into: lp:summit
Diff against target: 56 lines (+11/-2)
3 files modified
summit/linaro_settings.py (+5/-0)
summit/settings.py (+2/-2)
summit/ubuntu_settings.py (+4/-0)
To merge this branch: bzr merge lp:~cjohnston/summit/ga-templatetag
Reviewer Review Type Date Requested Status
Michael Hall (community) Approve
Review via email: mp+150674@code.launchpad.net

Commit message

Fixes Google Analytics by adding it as a templatetag

To post a comment you must log in.
lp:~cjohnston/summit/ga-templatetag updated
486. By Chris Johnston

Adds google analytics code

487. By Chris Johnston

Fixes issues with GA

488. By Chris Johnston

more fixes

489. By Chris Johnston

remove test code

490. By Chris Johnston

oops

Revision history for this message
Michael Hall (mhall119) wrote :

Looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'summit/linaro_settings.py'
--- summit/linaro_settings.py 2012-05-25 14:57:02 +0000
+++ summit/linaro_settings.py 2013-02-27 00:09:21 +0000
@@ -7,9 +7,14 @@
77
8SITE_ID = 28SITE_ID = 2
99
10# Google Analytics code
11GOOGLE_ANALYTICS_CODE = 'UA-30315860-1'
12
10try:13try:
11 import linaro_website14 import linaro_website
1215
16 INSTALLED_APPS.append('linaro_website')
17
13 TEMPLATE_CONTEXT_PROCESSORS += (18 TEMPLATE_CONTEXT_PROCESSORS += (
14 "linaro_website.media_processor",19 "linaro_website.media_processor",
15 "linaro_website.popup_check",20 "linaro_website.popup_check",
1621
=== modified file 'summit/settings.py'
--- summit/settings.py 2013-02-26 19:31:21 +0000
+++ summit/settings.py 2013-02-27 00:09:21 +0000
@@ -181,10 +181,10 @@
181 'bzr_apps': ('http://bazaar.launchpad.net/~django-foundations-dev/ubuntu-django-foundations/bzr_apps', '7'),181 'bzr_apps': ('http://bazaar.launchpad.net/~django-foundations-dev/ubuntu-django-foundations/bzr_apps', '7'),
182182
183 ## ubuntu-website supplied templates and styles183 ## ubuntu-website supplied templates and styles
184 'ubuntu_website': ('http://bazaar.launchpad.net/~ubuntu-community-webthemes/ubuntu-community-webthemes/light-django-theme', '49'),184 'ubuntu_website': ('http://bazaar.launchpad.net/~ubuntu-community-webthemes/ubuntu-community-webthemes/light-django-theme', '54'),
185185
186 ## linaro-website supplied templates and styles186 ## linaro-website supplied templates and styles
187 'linaro_website': ('http://bazaar.launchpad.net/~linaro-connect-theme-devs/ubuntu-community-webthemes/light-django-linaro-theme', '51'),187 'linaro_website': ('http://bazaar.launchpad.net/~linaro-connect-theme-devs/ubuntu-community-webthemes/light-django-linaro-theme', '52'),
188}188}
189189
190import logging190import logging
191191
=== modified file 'summit/ubuntu_settings.py'
--- summit/ubuntu_settings.py 2012-04-17 01:53:48 +0000
+++ summit/ubuntu_settings.py 2013-02-27 00:09:21 +0000
@@ -5,12 +5,16 @@
55
6SITE_ROOT = 'http://summit.ubuntu.com'6SITE_ROOT = 'http://summit.ubuntu.com'
77
8# Google Analytics code
9GOOGLE_ANALYTICS_CODE = 'UA-26810861-1'
810
9SITE_ID = 111SITE_ID = 1
1012
11try:13try:
12 import ubuntu_website14 import ubuntu_website
1315
16 INSTALLED_APPS.append('ubuntu_website')
17
14 TEMPLATE_CONTEXT_PROCESSORS += (18 TEMPLATE_CONTEXT_PROCESSORS += (
15 "ubuntu_website.media_processor",19 "ubuntu_website.media_processor",
16 "ubuntu_website.popup_check",20 "ubuntu_website.popup_check",

Subscribers

People subscribed via source and target branches