Merge lp:~cjohnston/summit/643050 into lp:summit

Proposed by Chris Johnston
Status: Merged
Approved by: Michael Hall
Approved revision: 90
Merged at revision: 92
Proposed branch: lp:~cjohnston/summit/643050
Merge into: lp:summit
Diff against target: 66 lines (+32/-0)
4 files modified
summit/schedule/templates/schedule/past_summit.html (+22/-0)
summit/schedule/templates/schedule/summit.html (+1/-0)
summit/schedule/views.py (+8/-0)
summit/urls.py (+1/-0)
To merge this branch: bzr merge lp:~cjohnston/summit/643050
Reviewer Review Type Date Requested Status
Michael Hall (community) Needs Fixing
Review via email: mp+59284@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Michael Hall (mhall119) wrote :

The link to the past summit should use {% url summit.schedule.views.summit summit.name %} rather than just "/{{summit.name}}"

review: Needs Fixing
lp:~cjohnston/summit/643050 updated
89. By Chris Johnston

Fixes URL, changes file name

90. By Chris Johnston

Adds new file

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== added file 'summit/schedule/templates/schedule/past_summit.html'
--- summit/schedule/templates/schedule/past_summit.html 1970-01-01 00:00:00 +0000
+++ summit/schedule/templates/schedule/past_summit.html 2011-04-27 20:50:58 +0000
@@ -0,0 +1,22 @@
1{% extends "base.html" %}
2{% load datetime %}
3{% load i18n %}
4
5{% block title %}{% trans 'Previous Ubuntu Developer Summits' %}{% endblock %}
6
7{% block sub_nav_links %}
8 <a class="sub-nav-item" href="{% url summit.schedule.views.summit next_summit.name %}">{% trans 'Current Summit' %}</a>
9{% endblock %}
10
11{% block content %}
12
13<article class="main-content">
14{% for summit in past_summit reversed %}
15<h1><a href="{% url summit.schedule.views.summit summit.name %} ">{{ summit.title }}</a></h1>
16<p>
17{% include "schedule/summit_info.html" %}
18</p>
19{% endfor %}
20</article>
21
22{% endblock %}
023
=== modified file 'summit/schedule/templates/schedule/summit.html'
--- summit/schedule/templates/schedule/summit.html 2011-04-02 00:34:06 +0000
+++ summit/schedule/templates/schedule/summit.html 2011-04-27 20:50:58 +0000
@@ -22,6 +22,7 @@
22 {% if attendee %}22 {% if attendee %}
23 <a class="sub-nav-item" href="/{{ summit.name }}/participant/{{ attendee.user.username }}.ical">{% trans 'My Sessions (iCal)' %}</a>23 <a class="sub-nav-item" href="/{{ summit.name }}/participant/{{ attendee.user.username }}.ical">{% trans 'My Sessions (iCal)' %}</a>
24 {% endif %}24 {% endif %}
25 <a class="sub-nav-item" href="{% url summit.schedule.views.past %}">{% trans 'Past Summits' %}</a>
25{% endblock %}26{% endblock %}
2627
27{% block content %}28{% block content %}
2829
=== modified file 'summit/schedule/views.py'
--- summit/schedule/views.py 2011-04-19 21:50:43 +0000
+++ summit/schedule/views.py 2011-04-27 20:50:58 +0000
@@ -267,3 +267,11 @@
267267
268def mobile(request):268def mobile(request):
269 return render_to_response("schedule/mobile.html", {}, RequestContext(request))269 return render_to_response("schedule/mobile.html", {}, RequestContext(request))
270
271def past(request):
272 pastsummit = Summit.objects.filter(date_end__lte=datetime.date.today())
273 context = {
274 'past_summit': pastsummit,
275 }
276 return render_to_response("schedule/past_summit.html", context,
277 context_instance=RequestContext(request))
270278
=== modified file 'summit/urls.py'
--- summit/urls.py 2011-04-20 14:44:33 +0000
+++ summit/urls.py 2011-04-27 20:50:58 +0000
@@ -54,6 +54,7 @@
5454
55urlpatterns += patterns('summit.schedule.views',55urlpatterns += patterns('summit.schedule.views',
56 (r'^today/$', 'today_view'),56 (r'^today/$', 'today_view'),
57 url(r'^past/', 'past', name='past'),
57 url(r'^mobile/', 'mobile', name='mobile'),58 url(r'^mobile/', 'mobile', name='mobile'),
58 url(r'^logout$', 'logout_view', name='logout'),59 url(r'^logout$', 'logout_view', name='logout'),
59 (r'^(?P<summit_name>[\w-]+)/$', 'summit'),60 (r'^(?P<summit_name>[\w-]+)/$', 'summit'),

Subscribers

People subscribed via source and target branches