Merge lp:~cjohnston/summit/643050 into lp:summit

Proposed by Chris Johnston
Status: Merged
Approved by: Michael Hall
Approved revision: 90
Merged at revision: 92
Proposed branch: lp:~cjohnston/summit/643050
Merge into: lp:summit
Diff against target: 66 lines (+32/-0)
4 files modified
summit/schedule/templates/schedule/past_summit.html (+22/-0)
summit/schedule/templates/schedule/summit.html (+1/-0)
summit/schedule/views.py (+8/-0)
summit/urls.py (+1/-0)
To merge this branch: bzr merge lp:~cjohnston/summit/643050
Reviewer Review Type Date Requested Status
Michael Hall (community) Needs Fixing
Review via email: mp+59284@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Michael Hall (mhall119) wrote :

The link to the past summit should use {% url summit.schedule.views.summit summit.name %} rather than just "/{{summit.name}}"

review: Needs Fixing
lp:~cjohnston/summit/643050 updated
89. By Chris Johnston

Fixes URL, changes file name

90. By Chris Johnston

Adds new file

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'summit/schedule/templates/schedule/past_summit.html'
2--- summit/schedule/templates/schedule/past_summit.html 1970-01-01 00:00:00 +0000
3+++ summit/schedule/templates/schedule/past_summit.html 2011-04-27 20:50:58 +0000
4@@ -0,0 +1,22 @@
5+{% extends "base.html" %}
6+{% load datetime %}
7+{% load i18n %}
8+
9+{% block title %}{% trans 'Previous Ubuntu Developer Summits' %}{% endblock %}
10+
11+{% block sub_nav_links %}
12+ <a class="sub-nav-item" href="{% url summit.schedule.views.summit next_summit.name %}">{% trans 'Current Summit' %}</a>
13+{% endblock %}
14+
15+{% block content %}
16+
17+<article class="main-content">
18+{% for summit in past_summit reversed %}
19+<h1><a href="{% url summit.schedule.views.summit summit.name %} ">{{ summit.title }}</a></h1>
20+<p>
21+{% include "schedule/summit_info.html" %}
22+</p>
23+{% endfor %}
24+</article>
25+
26+{% endblock %}
27
28=== modified file 'summit/schedule/templates/schedule/summit.html'
29--- summit/schedule/templates/schedule/summit.html 2011-04-02 00:34:06 +0000
30+++ summit/schedule/templates/schedule/summit.html 2011-04-27 20:50:58 +0000
31@@ -22,6 +22,7 @@
32 {% if attendee %}
33 <a class="sub-nav-item" href="/{{ summit.name }}/participant/{{ attendee.user.username }}.ical">{% trans 'My Sessions (iCal)' %}</a>
34 {% endif %}
35+ <a class="sub-nav-item" href="{% url summit.schedule.views.past %}">{% trans 'Past Summits' %}</a>
36 {% endblock %}
37
38 {% block content %}
39
40=== modified file 'summit/schedule/views.py'
41--- summit/schedule/views.py 2011-04-19 21:50:43 +0000
42+++ summit/schedule/views.py 2011-04-27 20:50:58 +0000
43@@ -267,3 +267,11 @@
44
45 def mobile(request):
46 return render_to_response("schedule/mobile.html", {}, RequestContext(request))
47+
48+def past(request):
49+ pastsummit = Summit.objects.filter(date_end__lte=datetime.date.today())
50+ context = {
51+ 'past_summit': pastsummit,
52+ }
53+ return render_to_response("schedule/past_summit.html", context,
54+ context_instance=RequestContext(request))
55
56=== modified file 'summit/urls.py'
57--- summit/urls.py 2011-04-20 14:44:33 +0000
58+++ summit/urls.py 2011-04-27 20:50:58 +0000
59@@ -54,6 +54,7 @@
60
61 urlpatterns += patterns('summit.schedule.views',
62 (r'^today/$', 'today_view'),
63+ url(r'^past/', 'past', name='past'),
64 url(r'^mobile/', 'mobile', name='mobile'),
65 url(r'^logout$', 'logout_view', name='logout'),
66 (r'^(?P<summit_name>[\w-]+)/$', 'summit'),

Subscribers

People subscribed via source and target branches