The word is "whitelist", not "white list". This is not exactly very
important, but since you are changing some parts of it, you might fix it
on the lines you are touching anyway.
> /**
> - * Add a network interface index number to the list of white listed
> + * Add a network interface index number plus label to the list of white listed
whitelisted
> * @param if_index the network interface index to be white listed
> + * @param device_name the network interface label to be white listed
> @@ -117,17 +126,22 @@
>
> /**
> - * Test if the given network interface index is white listed.
> + * Test if the given network interface index plus label is white listed.
whitelisted
> @@ -1120,6 +1133,40 @@
>
> /**
> + * Gives you the interface label for a given IPv4 or IPv6 address.
> + *
> + * @param addr address for which you want to know the label
> + * @param label pointer where the function stores the label
review needs-fixing
On Mon, Aug 22, 2011 at 11:47:44AM +0000, Christian Röller wrote:
> Christian Röller has proposed merging lp:~christian-roeller/hipl/whitelisting into lp:hipl.
The word is "whitelist", not "white list". This is not exactly very
important, but since you are changing some parts of it, you might fix it
on the lines you are touching anyway.
> --- hipd/netdev.c 2011-08-15 14:11:56 +0000 white_list[ HIP_NETDEV_ MAX_WHITE_ LIST]; white_list_ count = 0; whiteliste_ entry { IF_NAMESIZE] ; whiteliste_ entry hip_netdev_ white_list[ HIP_NETDEV_ MAX_WHITE_ LIST]; white_list_ count = 0;
> +++ hipd/netdev.c 2011-08-22 11:47:21 +0000
> @@ -97,19 +97,28 @@
> -static int hip_netdev_
> -static int hip_netdev_
> +struct hip_netdev_
> + unsigned int if_index;
> + char if_label[
> +};
> +static struct hip_netdev_
> +static unsigned int hip_netdev_
whitelist, not whitelistE
> /**
> - * Add a network interface index number to the list of white listed
> + * Add a network interface index number plus label to the list of white listed
whitelisted
> * @param if_index the network interface index to be white listed
> + * @param device_name the network interface label to be white listed
whitelisted
> */ white_list_ add_index( int if_index) white_list_ add_index_ and_name( const unsigned int if_index,
> -static void hip_netdev_
> +static void hip_netdev_
> + const char *const device_name)
whitelist
> @@ -117,17 +126,22 @@
>
> /**
> - * Test if the given network interface index is white listed.
> + * Test if the given network interface index plus label is white listed.
whitelisted
> @@ -1120,6 +1133,40 @@
>
> /**
> + * Gives you the interface label for a given IPv4 or IPv6 address.
> + *
> + * @param addr address for which you want to know the label
> + * @param label pointer where the function stores the label
nit: please vertically align the descriptions.
Diego