Merge lp:~chipaca/ubuntu-push/watchticker into lp:ubuntu-push
Proposed by
John Lenton
Status: | Merged |
---|---|
Approved by: | Samuele Pedroni |
Approved revision: | no longer in the source branch. |
Merged at revision: | 31 |
Proposed branch: | lp:~chipaca/ubuntu-push/watchticker |
Merge into: | lp:ubuntu-push |
Diff against target: |
117 lines (+54/-10) 3 files modified
bus/connectivity/connectivity_test.go (+19/-9) bus/testing/testing_endpoint.go (+9/-1) bus/testing/testing_endpoint_test.go (+26/-0) |
To merge this branch: | bzr merge lp:~chipaca/ubuntu-push/watchticker |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Samuele Pedroni | Approve | ||
Review via email: mp+203639@code.launchpad.net |
This proposal supersedes a proposal from 2014-01-27.
Commit message
Made bus.Endpoint's WatchSignal use an (exported) channel for waiting between sending values, if the channel is not nil.
Description of the change
made bus.Endpoint's WatchSignal use an (exported) channel for waiting between sending values, if the channel is not nil.
To post a comment you must log in.
66 +var WatchTicker chan rune
using a rune here is a bit confusing, maybe
type TickT rune
const Tick TickT = 'x'
chan TickT
37 + for _, b := range expected.ticks { WatchTicker <- b
38 + testingbus.
39 + }
that's cute but also fairly obscure, also b sounds like a byte or boolean, not rune, expected ticks cool be just a bool no? or are always ticking once or not