Code review comment for lp:~chipaca/ubuntu-push/bus-endpoint-wachticker

Revision history for this message
Samuele Pedroni (pedronis) wrote :

66 +var WatchTicker chan rune

using a rune here is a bit confusing, maybe

type TickT rune

const Tick TickT = 'x'

chan TickT

37 + for _, b := range expected.ticks {
38 + testingbus.WatchTicker <- b
39 + }

that's cute but also fairly obscure, also b sounds like a byte or boolean, not rune, expected ticks cool be just a bool no? or are always ticking once or not

« Back to merge proposal