Code review comment for lp:~chipaca/ubuntu-push/networkmanager

Revision history for this message
Samuele Pedroni (pedronis) wrote :

+ return NetworkManager{conn, log}

the struct is big enough that that should return a pointer and the methods be on pointers

218 +func (nm State) String() string {

nm should be state there

the const group ins state, NetworkManager and New need docs

according to coverage this is not hit by tests:

67 + func() { close(ch) })

« Back to merge proposal