Merge lp:~chipaca/ubuntu-push/networkmanager into lp:ubuntu-push
Proposed by
John Lenton
Status: | Merged |
---|---|
Approved by: | John Lenton |
Approved revision: | 15 |
Merged at revision: | 11 |
Proposed branch: | lp:~chipaca/ubuntu-push/networkmanager |
Merge into: | lp:ubuntu-push |
Prerequisite: | lp:~chipaca/ubuntu-push/simple-bus-interface |
Diff against target: |
285 lines (+240/-3) 5 files modified
bus/testing/testing_bus.go (+2/-2) bus/testing/testing_endpoint.go (+1/-1) networkmanager/networkmanager.go (+85/-0) networkmanager/networkmanager_test.go (+100/-0) networkmanager/state.go (+52/-0) |
To merge this branch: | bzr merge lp:~chipaca/ubuntu-push/networkmanager |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Samuele Pedroni | Approve | ||
Review via email:
|
Commit message
A simplified, testable, Network Manager wrapper
Description of the change
A very small, partial, wrapper around network manager.
To post a comment you must log in.
+ return NetworkManager{ conn, log}
the struct is big enough that that should return a pointer and the methods be on pointers
218 +func (nm State) String() string {
nm should be state there
the const group ins state, NetworkManager and New need docs
according to coverage this is not hit by tests:
67 + func() { close(ch) })