Code review comment for lp:~chipaca/snappy/serve

Revision history for this message
Michael Vogt (mvo) wrote :

We have golang-go-systemd-dev v2 in the archive which will work fine with go1.3. So its only a problem in CI AFAICT. It seems like the easiest way to unblock this would be to update dependencies.tsv to point to the v2 commit ? Unfortuantely it seems like godeps files can not have comments so I can add a comment why this commit was chosen in the file itself.

Would this help?
"""
=== modified file 'dependencies.tsv'
--- dependencies.tsv 2015-09-09 13:46:17 +0000
+++ dependencies.tsv 2015-09-14 09:04:21 +0000
@@ -1,6 +1,6 @@
 github.com/blakesmith/ar git c9a977dd0cc1392b023382c7bfa5a22af8d3b7302013-02-19T04:59:55Z
 github.com/cheggaaa/pb git e8c7cc515bfde3e267957a3b110080ceed51354e 2014-12-02T07:01:21Z
-github.com/coreos/go-systemd git 392c689e425689acb51976419a8d62878966511f2015-09-08T19:15:25Z
+github.com/coreos/go-systemd git f743bc15d6bddd23662280b4ad20f7c874cdd5ad2015-09-08T19:15:25Z
 github.com/gorilla/context git 1c83b3eabd45b6d76072b66b746c20815fb2872d2015-08-20T05:12:45Z
 github.com/gorilla/mux git ee1815431e497d3850809578c93ab6705f1a19f7 2015-08-20T05:15:06Z
 github.com/gosexy/gettext git 98b7b91596d20b96909e6b60d57411547dd9959c2013-02-21T11:21:43Z
"""

« Back to merge proposal