Merge lp:~chipaca/snappy/serve into lp:~snappy-dev/snappy/snappy-moved-to-github
| Status: | Merged |
|---|---|
| Approved by: | John Lenton on 2015-09-14 |
| Approved revision: | 658 |
| Merged at revision: | 674 |
| Proposed branch: | lp:~chipaca/snappy/serve |
| Merge into: | lp:~snappy-dev/snappy/snappy-moved-to-github |
| Diff against target: |
580 lines (+497/-1) 10 files modified
cmd/snapd/main.go (+65/-0) daemon/api.go (+54/-0) daemon/api_test.go (+132/-0) daemon/daemon.go (+125/-0) daemon/response.go (+107/-0) debian/control (+3/-0) debian/ubuntu-snappy-cli.install (+1/-0) dependencies.tsv (+4/-0) po/snappy.pot (+1/-1) release/release.go (+5/-0) |
| To merge this branch: | bzr merge lp:~chipaca/snappy/serve |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michael Vogt | 2015-09-08 | Approve on 2015-09-09 | |
|
Review via email:
|
|||
Commit Message
Introducing snapd.
Description of the Change
Initial daemon branch.
| Leo Arias (elopio) wrote : | # |
| John Lenton (chipaca) wrote : | # |
Fixed, thank you!
To test you can use systemd-activate(8) on a snappy system.
| Michael Vogt (mvo) wrote : | # |
Hey, thanks a bunch! This looks very good, I have lots of silly questions in the comments but given our tight deadline feel free to ignore, nothing that needs fixing.
| Michael Vogt (mvo) wrote : | # |
Looks like we will have to backport "golang-
With the following diff I can build the package:
"""
=== modified file 'daemon/daemon.go'
--- daemon/daemon.go 2015-09-09 09:22:36 +0000
+++ daemon/daemon.go 2015-09-09 12:07:32 +0000
@@ -25,7 +25,7 @@
"net/http"
"github.
- "github.
+ "github.
"gopkg.
"launchpad.
=== modified file 'debian/control'
--- debian/control 2015-07-21 19:07:56 +0000
+++ debian/control 2015-09-09 12:05:57 +0000
@@ -18,6 +18,9 @@
+ golang-mux-dev,
+ golang-
+ golang-
Standards-Version: 3.9.6
=== modified file 'debian/
--- debian/
+++ debian/
@@ -1,4 +1,5 @@
/usr/bin/snappy
+/usr/bin/snapd
data/completio
# i18n stuff
../../share /usr
"""
Note that I switched from lxd-go-
| Michael Vogt (mvo) wrote : | # |
Feel free to top-approve once the above diff (or something similar) lands and its bzr-buildpackage able.
| Snappy Tarmac (snappydevtarmac) wrote : | # |
The attempt to merge lp:~chipaca/snappy/serve into lp:snappy failed. Below is the output from the failed tests.
Checking docs
Checking formatting
Installing godeps
Install golint
Obtaining dependencies
update github.
update github.
github.
update github.
github.
update gopkg.in/tomb.v2 failed; trying to fetch newer version
github.
update github.
gopkg.in/tomb.v2 now at 14b3d72120e8d10
update github.
github.
update github.
github.
update github.
github.
update github.
github.
update github.
github.
update golang.org/x/crypto failed; trying to fetch newer version
github.
update gopkg.in/check.v1 failed; trying to fetch newer version
golang.org/x/crypto now at 60052bd85f2d912
update gopkg.in/yaml.v2 failed; trying to fetch newer version
gopkg.in/check.v1 now at 64131543e7896d5
gopkg.in/yaml.v2 now at 49c95bdc2184325
Building
# we always run in a fresh dir in tarmac
export GOPATH=$(mktemp -d)
trap 'rm -rf "$GOPATH"' EXIT
# this is a hack, but not sure tarmac is golang friendly
mkdir -p $GOPATH/
cp -a . $GOPATH/
cd $GOPATH/
./run-checks
if which goctest >/dev/null; then
goctest=
else
goctest="go test"
fi
echo Checking docs
./mdlint.py docs/*.md
echo Checking formatting
fmt=$(gofmt -l .)
if [ -n "$fmt" ]; then
echo "Formatting wrong in following files"
echo "$fmt"
exit 1
fi
echo Installing godeps
go get launchpad.
export PATH=$PATH:
echo Install golint
go get github.
export PATH=$PATH:
echo Obtaining dependencies
godeps -u dependencies.tsv
echo Building
go build -v launchpad.
daemon/
/usr/lib/
/tmp/tmp.
| Snappy Tarmac (snappydevtarmac) wrote : | # |
The attempt to merge lp:~chipaca/snappy/serve into lp:snappy failed. Below is the output from the failed tests.
Checking docs
Checking formatting
Installing godeps
Install golint
Obtaining dependencies
update github.
update github.
github.
update github.
github.
update github.
github.
update github.
github.
update github.
github.
update golang.org/x/crypto failed; trying to fetch newer version
github.
update gopkg.in/check.v1 failed; trying to fetch newer version
golang.org/x/crypto now at 60052bd85f2d912
update gopkg.in/yaml.v2 failed; trying to fetch newer version
gopkg.in/check.v1 now at 64131543e7896d5
update github.
gopkg.in/yaml.v2 now at 49c95bdc2184325
update github.
github.
update github.
github.
update gopkg.in/tomb.v2 failed; trying to fetch newer version
github.
gopkg.in/tomb.v2 now at 14b3d72120e8d10
Building
# we always run in a fresh dir in tarmac
export GOPATH=$(mktemp -d)
trap 'rm -rf "$GOPATH"' EXIT
# this is a hack, but not sure tarmac is golang friendly
mkdir -p $GOPATH/
cp -a . $GOPATH/
cd $GOPATH/
./run-checks
if which goctest >/dev/null; then
goctest=
else
goctest="go test"
fi
echo Checking docs
./mdlint.py docs/*.md
echo Checking formatting
fmt=$(gofmt -l .)
if [ -n "$fmt" ]; then
echo "Formatting wrong in following files"
echo "$fmt"
exit 1
fi
echo Installing godeps
go get launchpad.
export PATH=$PATH:
echo Install golint
go get github.
export PATH=$PATH:
echo Obtaining dependencies
godeps -u dependencies.tsv
echo Building
go build -v launchpad.
github.
launchpad.
launchpad.
github.
# github.
../../github.
../../github.
| Leo Arias (elopio) wrote : | # |
Any idea what's this about?
../../github.
../../github.
I get it in vivid, not in wily.
| John Lenton (chipaca) wrote : | # |
yes, os.Unsetenv is not in go 1.3.
On 13 September 2015 at 01:39, Leo Arias <email address hidden> wrote:
> Any idea what's this about?
> ../../github.
> ../../github.
>
> I get it in vivid, not in wily.
> --
> https:/
> You are the owner of lp:~chipaca/snappy/serve.
| Leo Arias (elopio) wrote : | # |
> yes, os.Unsetenv is not in go 1.3.
Should I upgrade tarmac to wily?
| John Lenton (chipaca) wrote : | # |
no, because 15.04 is what we target stable at. The fix here is to
either package stgraber's version (which i was using originally), or
patch the coreos one with stgraber's patch.
On 13 September 2015 at 02:14, Leo Arias <email address hidden> wrote:
>> yes, os.Unsetenv is not in go 1.3.
>
> Should I upgrade tarmac to wily?
> --
> https:/
> You are the owner of lp:~chipaca/snappy/serve.
| Michael Vogt (mvo) wrote : | # |
We have golang-
Would this help?
"""
=== modified file 'dependencies.tsv'
--- dependencies.tsv 2015-09-09 13:46:17 +0000
+++ dependencies.tsv 2015-09-14 09:04:21 +0000
@@ -1,6 +1,6 @@
github.
github.
-github.
+github.
github.
github.
github.
"""
| Snappy Tarmac (snappydevtarmac) wrote : | # |
Attempt to merge into lp:snappy failed due to conflicts:
text conflict in po/snappy.pot
| Snappy Tarmac (snappydevtarmac) wrote : | # |
There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions.


I think you need to update the dependencies.tsv.
Some tiny comments in the diff...