Code review comment for lp:~chasedouglas/grail/fix-hold-reject

Revision history for this message
Chase Douglas (chasedouglas) wrote :

Yes, it could probably be moved up for the most part. The main reason it's not already is that the atomic recognizer has to maintain an extra list of touches: new_touches_.

There are multiple ways of skinning this cat:

* Create one big virtual function in recognizer.cpp, and have atomic-recognizer override it as it is currently written.

* Create virtual functions for each touch state.

* Something else?

I haven't really taken the time to think much about it. It would be an unnecessary code change, and at this point in the cycle we need to minimize such changes.

« Back to merge proposal