lp:~chasedouglas/grail/fix-hold-reject
- Get this branch:
- bzr branch lp:~chasedouglas/grail/fix-hold-reject
Branch merges
- Stephen M. Webb (community): Approve
- Thomas Voß (community): Needs Information
-
Diff: 105 lines (+22/-12)6 files modifiedsrc/v3/atomic-recognizer.cpp (+9/-1)
src/v3/atomic-recognizer.h (+2/-0)
src/v3/recognizer.cpp (+0/-9)
src/v3/recognizer.h (+0/-1)
src/v3/regular-recognizer.cpp (+9/-1)
src/v3/regular-recognizer.h (+2/-0)
Related bugs
Bug #972012: Touchscreen touches are not rejected until they end | High | Fix Released |
Related blueprints
Branch information
Recent revisions
- 228. By Chase Douglas
-
Maintain weak reference to all touches for updating state
If we hold a full reference, we won't allow for touch rejection until the
touch physically ends. Rather, we should hold a weak reference for the
purpose of updating the touch state. If the touch is rejected (deleted),
we can detect it and remove it from the all_touches_ array. Otherwise, we
delete the all_touches_ reference once the touch has logically ended.The all_touches_ array has been moved into the subclass recognizers. This
helps ensure the touch updating is performed in only one logical unit
without interference from other classes. - 227. By Chase Douglas
-
Don't bother deleting touch records in recognizer superclass
The touch records are already updated and deleted in the subclasses.
- 226. By Chase Douglas
-
Delete subscription in test fixture TearDown() method
The subscription is "owned" by the test fixture, so it should be deleted
by it, not by the test itself.
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:grail