Code review comment for lp:~charlesk/indicator-location/sync-with-platform-api-changes-to-accuracy-and-service

Revision history for this message
Ted Gould (ted) wrote :

On Wed, 2014-01-29 at 00:20 +0000, Charles Kerr wrote:

> UALocationServiceStatusFlags is an enum with the fields
> "UA_LOCATION_SERVICE_GPS_ENABLED" and "UA_LOCATION_SERVICE_ENABLED",
> so 0 means neither are enabled. So we're in agreement about what the
> Controller's initial status should be (and is) before
> ua_location_service_controller_query_status() is called.

I think that it would make total sense if that is what it was, but it's
not :-( It seems to be a field with both enable and disabled flags that
are independent of each other.

http://bazaar.launchpad.net/~phablet-team/platform-api/trunk/view/head:/include/ubuntu/application/location/controller.h#L30

« Back to merge proposal