lp:~charlesk/indicator-location/sync-with-platform-api-changes-to-accuracy-and-service

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:indicator-location/14.10 at revision 81

Ted Gould (community): Approve on 2014-05-27

PS Jenkins bot: Pending (continuous-integration) requested 2014-05-27

Diff: 778 lines (+504/-112)

8 files modified

CMakeLists.txt (+5/-1)
src/CMakeLists.txt (+14/-25)
src/controller-ualc.cc (+37/-52)
src/controller-ualc.h (+5/-4)
tests/CMakeLists.txt (+33/-14)
tests/gtest-dbus-fixture.h (+23/-16)
tests/ualc-mock.c (+152/-0)
tests/ualc-test.cc (+235/-0)

api

Superseded for merging into lp:indicator-location/14.04

PS Jenkins bot: Pending (continuous-integration) requested 2014-05-27

Ted Gould: Pending requested 2014-05-27

Diff: 770 lines (+503/-112)

8 files modified

CMakeLists.txt (+2/-1)
src/CMakeLists.txt (+16/-25)
src/controller-ualc.cc (+37/-52)
src/controller-ualc.h (+5/-4)
tests/CMakeLists.txt (+33/-14)
tests/gtest-dbus-fixture.h (+23/-16)
tests/ualc-mock.c (+152/-0)
tests/ualc-test.cc (+235/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1248973: The location and gps check box don't stay checked

High

Fix Released

Link a bug report

Related blueprints

80. By Charles Kerr on 2014-05-27

fix copy-paste bug introduced by copying cmake files from indicator-datetime

79. By Charles Kerr on 2014-01-29

remove a dead store assignment in controller-ualc's constructor

78. By Charles Kerr on 2014-01-27

add unit tests to confirm that Controller notifies with the correct status when the ualc's status changes.

77. By Charles Kerr on 2014-01-27

add unit tests to confirm that our mock ualc works, and that the production Controller keeps in sync with it

76. By Charles Kerr on 2014-01-27

add a mock implementation of the platform location API for our unit tests

75. By Charles Kerr on 2014-01-27

prepare for adding unit tests for ualc: fix unnecessary g_warning() console message in our test harness

74. By Charles Kerr on 2014-01-26

copyediting: more understandable variable name

73. By Charles Kerr on 2014-01-26

consistency in UbuntuAppLocController::set_state()

72. By Charles Kerr on 2014-01-26

minor copyediting: use consistent terminology 'status' instead of 'state'

71. By Charles Kerr on 2014-01-26

failing to get a ualc in the UbuntuAppLocController constructor should be impossible, so instead of just safeguarding by doing a nullptr test before using, use g_return_if_fail() so a console message will get logged too.