Ubuntu
update-notifier package

Code review comment for ~chad.smith/ubuntu/+source/update-notifier:groovy-esm-product-url-renaming

  1. Git
  2. lp:~chad.smith/ubuntu/+source/update-notifier
  3. groovy-esm-product-url-renaming
  4. Merge into ubuntu/groovy-proposed
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Bug 1901627 now has proper test steps - that former need is fixed.

You also explained on the same bug why you need to update the translations (thanks).
But if it it is indeed a change for the same overall cause then instead of:

870 + * data/apt_check.py: Update UA Infra: ESM product name and doc url
871 + (LP: #1901627)
872 + - data/apt_check.py: Update name and URL
873 + - tests/test_motd.py: adapt unittests to match new behavior
874 + * po/*.po: translation files with intltool-update -r

it should be

870 + * data/apt_check.py: Update UA Infra: ESM product name and doc url
871 + (LP: #1901627)
872 + - data/apt_check.py: Update name and URL
873 + - tests/test_motd.py: adapt unittests to match new behavior
874 + - po/*.po: translation files with intltool-update -r

review: Needs Fixing

« Back to merge proposal