Code review comment for ~chad.smith/ubuntu/+source/update-notifier:xenial-esm-product-url-renaming

SRU pre-req - All three commits are in 3.192.36 which is in hirsute

 update-notifier | 3.192.36 | hirsute | source, amd64, arm64, armhf, ppc64el, riscv64, s390x

Xenial is at
 update-notifier | 3.168.11 | xenial-proposed | source, amd64, arm64, armhf, i386, powerpc, ppc64el, s390x
You base on
pkg/import/3.168.11
=> OK

Please do mind that 3.168.11 didn't leave proposed yet.
You'll want that to happen before you upload this one.
Please clear https://bugs.launchpad.net/ubuntu/+source/update-notifier/+bug/1881632 and verify it for X/B/F to get completed.
If this is intentional (both changes shall land at once) - then please let me know, we'll need to buildpkg the changes file accordingly on an upload to include both versions. But in any way 1881632 will have to be verified sooner or later.

^^ needs info

The changelog IMHO doesn't mention all changes:

- For example the unittest changes.
  Since it is a sub-element of the URL rename you can list it as that like:
    * data/apt_check.py: Update UA Infra: ESM product name and doc url
      (LP: #1901627)
      - data/apt_check.py: Update name and URL
      - tests/test_motd.py: adapt unittests to match new behavior

The update to the translations looks correct, but has nothing to do with the URL/Rename.
Therefore it will IMHO need an extra bug that describes "why it has to be SRUed" and "how it shall be verified". If I miss how this is tied to the rename, then explain on the existing bug 1901627 why it is needed for it.

The bug 1901627 for the rename shows current and expected messaging (ok).
But it misses the steps how to trigger that output (it is MOTD; but are there also other ways, do I need to run an update after upgrading, ...)
In general you'll need to add a proper SRU template (https://wiki.ubuntu.com/StableReleaseUpdates#SRU_Bug_Template) to the bug unless you have a special exception. If you do so, then follow whatever this defines, but mention and link it in the bug.
It will likely need also a good paragraph why such a "messaging only" justifies an SRU. I know it is important from the Product POV, but you'll have to make that case in the SRU section of the bug.