Code review comment for ~chad.smith/ubuntu/+source/ubuntu-advantage-tools:release-27-impish

1. All the builds are getting this lintian error:
    E: ubuntu-advantage-tools source: build-depends-on-essential-package-without-using-version build-depends: debianutils

That is more of a warning in the sense that generally essential packages like debianutils will always be present on the system so don't need to be specifically listed. The one situation where you might list it is if a particular version requirement exists. So, if this was added deliberately you may want to set the required version.

Otherwise I suspect this is innocuous and will ignore.

2. In the changelog, couple minor typos:
  * ammend -> amend
  * ommitted -> omitted

    W: ubuntu-advantage-pro: spelling-error-in-changelog ammend amend
    W: ubuntu-advantage-pro: spelling-error-in-changelog ommitted omitted
    W: ubuntu-advantage-tools: spelling-error-in-changelog ammend amend
    W: ubuntu-advantage-tools: spelling-error-in-changelog ommitted omitted

3. On xenial, we're getting this lintian error:

   E: ubuntu-advantage-tools source: invalid-arch-string-in-source-relation riscv64 [build-depends: golang-1.10-go [!powerpc !riscv64]]

   I'm guessing it just means that xenial's lintian just isn't aware of riscv64. Assuming that to be the case I think we can ignore this as a bug in lintian?

4. Package build shows these lintian warnings:

a. W: ubuntu-advantage-pro: systemd-service-file-refers-to-unusual-wantedby-target lib/systemd/system/ua-auto-attach.service cloud-config.service

I think that ones just an overly aggressive warning, and is appropriate to add a lintian override for.

b. W: ubuntu-advantage-tools: hardening-no-pie usr/lib/ubuntu-advantage/apt-esm-json-hook

No idea how pertinent this warning is, but the description is at https://lintian.debian.org/tags/hardening-no-pie

c. W: ubuntu-advantage-tools: hardening-no-relro usr/lib/ubuntu-advantage/apt-esm-json-hook

For this one it sounds like it just needs a tweak to the compiler flags - https://lintian.debian.org/tags/hardening-no-relro

5. impish (only) has a build failure testing python hooks:

python3 -m pytest
============================= test session starts ==============================
platform linux -- Python 3.9.4, pytest-6.0.2, py-1.10.0, pluggy-0.13.0
rootdir: /home/bryce/pkg/UbuntuAdvantageTools/review-27.0.2-impish/ubuntu-advantage-tools-gu-build, configfile: tox.ini
collected 1164 items / 1 error / 1163 selected

==================================== ERRORS ====================================
_________ ERROR collecting uaclient/tests/test_ua_update_messaging.py __________
ImportError while importing test module '/home/bryce/pkg/UbuntuAdvantageTools/review-27.0.2-impish/ubuntu-advantage-tools-gu-build/uaclient/tests/test_ua_update_messaging.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/lib/python3.9/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
uaclient/tests/test_ua_update_messaging.py:25: in <module>
    from lib.ua_update_messaging import (
E ModuleNotFoundError: No module named 'lib.ua_update_messaging'

I again was able to work around this by touch lib/__init__.py and re-building. It's weird I hit this only on the impish build. Seems like last time it was only on the hirsute build.

6. xenial (only) has a build failure with testing the hooks:

make -C apt-hook test
make[2]: Entering directory '/home/bryce/pkg/UbuntuAdvantageTools/review-27.0.2-xenial/ubuntu-advantage-tools-gu-build/apt-hook'
[ "" ] || (cd json-hook-src && GOCACHE=/tmp/ /usr/bin/go test)
# _/home/bryce/pkg/UbuntuAdvantageTools/review-27.0.2-xenial/ubuntu-advantage-tools-gu-build/apt-hook/json-hook-src
./json-hook_test.go:47: t.Run undefined (type *testing.T has no field or method Run)
./json-hook_test.go:69: t.Run undefined (type *testing.T has no field or method Run)
FAIL _/home/bryce/pkg/UbuntuAdvantageTools/review-27.0.2-xenial/ubuntu-advantage-tools-gu-build/apt-hook/json-hook-src [build failed]
Makefile:41: recipe for target 'test' failed
make[2]: *** [test] Error 2
make[2]: Leaving directory '/home/bryce/pkg/UbuntuAdvantageTools/review-27.0.2-xenial/ubuntu-advantage-tools-gu-build/apt-hook'
debian/rules:30: recipe for target 'override_dh_auto_test' failed
make[1]: *** [override_dh_auto_test] Error 2
make[1]: Leaving directory '/home/bryce/pkg/UbuntuAdvantageTools/review-27.0.2-xenial/ubuntu-advantage-tools-gu-build'
debian/rules:22: recipe for target 'build' failed
make: *** [build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2
debuild: fatal error at line 1376:
dpkg-buildpackage -rfakeroot -D -us -uc -i -I.bzr -I.svn -I.git failed

Items 1-5 should be looked into but I don't consider them absolutely required for this upload. But #6 seems important to sort out before uploading for xenial at least.