Code review comment for ~chad.smith/ubuntu/+source/ubuntu-advantage-tools:release-27-impish

This is now properly based on pkg/ubuntu/impish-devel == import/27.0.1 - thanks!
I've already confirmed that the other branches all are now properly based on this.

Since thereby this branch is the base of all the others I'm re-reviewing the individual changes to be extra sure ...

old: upload/27.0.1..bd4f0d51
new: import/27.0.1..chad.smith/release-27-impish

Range diff confirms that the new code matches the old (already reviewed) code exactly except the update to the changelog.

 1: 1d9365af = 1: 00c61952 sync ubuntu pkg branch changelog
 2: 4572a943 = 2: 24b8bfbf apt-hook: run new json hook tests on package build
 3: 6d42915e = 3: 55f4c80f apt-hook: ignore build artifacts in git
 4: b32b4760 = 4: 05e2ad87 apt-hook: refactor json hook messaging to be dry
 5: 4053b400 = 5: 3451bb6c apt-hook: ignore go hook on some architectures
 6: d32eef4b = 6: 10fd37ea build: order build-depends alternatives newer first
 7: f30579b2 = 7: 2880c9d2 tests: fix subp ls error case
 8: 3bfe06c8 ! 8: 28d0e330 changelog 27.0.1 & 27.0.2
 9: bd4f0d51 ! 9: 32bcbd07 jenkinsfile: trusty sbuild --resolve-depends for CI runs
 -: -------- > 10: 6669606a changelog: add bugs for riscv64 and powerpc builds

28d0e330 changelog 27.0.1 & 27.0.2
  This now needlessly modifies the stanza of 27.0.1
  - removes "apt-hook: mitigate failures with true" (which isn't true, that happened and is in
    27.0.1); This shows this is present
    $ git show import/27.0.1:apt-hook/20apt-esm-hook.conf
  - Bumps the date Wed, 28 Apr 2021 -> Fri, 07 May 2021 (which isn't true either)

=> Please remove that hunk modifying 27.0.1, the actual new changelog of 27.0.2 on top is fine.

32bcbd07 jenkinsfile: trusty sbuild --resolve-depends for CI runs
6669606a changelog: add bugs for riscv64 and powerpc builds

These two are ok, the old bd4f0d51 was combining changelog+functional change and it is now properly split into 32bcbd07+6669606a

So you are a minimal changes away from having all in place to be sponsorable.

P.S. Please remember to rebase all the other MPs for H/G/F/B/X onto the new impish branch as well then