Code review comment for lp:~chad.smith/landscape-client/avoid-metadata-pycurl-traceback

Revision history for this message
Chad Smith (chad.smith) wrote :

Hi Free,

   I think I have addressed your review comments. I have now separated the fetch_ec2_meta_data functions out into their own very simple cloud.py library with local unit tests.

I have left a number of computerinfo meta-data tests intact as they represented integration tests using the results of fetch_ec2_meta_data. I have also boiled down a bit of the existing computerinfo meta-data unit tests, dropping some duplicated add_query_results which are handled by the test class' setUp method.

« Back to merge proposal