lp:~chad.smith/landscape-client/avoid-metadata-pycurl-traceback

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:~landscape/landscape-client/trunk at revision 719

Chris Glass (community): Approve on 2013-09-06

Free Ekanayaka (community): Approve on 2013-09-05

Diff: 446 lines (+258/-92)

4 files modified

landscape/lib/cloud.py (+45/-0)
landscape/lib/tests/test_cloud.py (+107/-0)
landscape/monitor/computerinfo.py (+28/-51)
landscape/monitor/tests/test_computerinfo.py (+78/-41)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1216689: Monitor logs full of cloud meta-data connection errors

Low

Fix Released

Link a bug report

Related blueprints

728. By Chad Smith on 2013-09-07

shuffle METADATA_RETRY_MAX logic and fetch_ec2_metadata from send_computer_message and into _create_computer_message

727. By Chad Smith on 2013-09-06

fetch_cloud_meta_data -> fetch_ec2_meta_data

726. By Chad Smith on 2013-09-05

address free's remaining comments:
 - fetch_ec2_item made private
 - METADATA_RETRY_MAX moved from lib/cloud into computerinfo.py
 - drop retry logging message and handle all logging on computerinfo
 - metadata query failure is not a real failure, just info message for non-cloud computers

725. By Chad Smith on 2013-09-04

lints

724. By Chad Smith on 2013-09-04

shuffle ec2 metadata calls out into their own library landscape/lib/cloud and associated unit tests. clean up excess add_query_results from test_computerinfo which are already handled by setUp.

723. By Chad Smith on 2013-09-03

handle review comments:
 - use 3 retries for all error types (don't bail on 1st PyCurl error)
 - lint fixes

Decided to drop generic error strings and instead let the error content passthrough to logs by using error.getErrorMessage(). This cleans PyCurl stack trace error messages.

722. By Chad Smith on 2013-08-30

one more test to assert fetch_cloud_meta_data is not called when _check_cloud = False

721. By Chad Smith on 2013-08-30

set _check_cloud to False when we have valid cloud data to prevent unneeded additional queries on next message exchange

720. By Chad Smith on 2013-08-30

lints

719. By Chad Smith on 2013-08-30

- reduce amount of logging noise during EC2 metadata queries on client
- avoid printing pycurl tracebacks for "couldn't connect to host" messages
- add a metadata retry of 3 in case of spurious EC2 404s
- unit tests