Merge ~chad.smith/cloud-init:cleanup/test-failures-print-testname into cloud-init:master

[Chad Smith]

tests: print failed testname instead of docstring upon failure

to validate:

Add a failed assertion to some test and run tox -e py27 tests/unittests/test_log.py with and without this merge proposal.
See the docstring of the test on master and the failed test name test_logger_uses_gmtime

diff --git a/tests/unittests/test_log.py b/tests/unittests/test_log.py
index cd6296d..6802ab5 100644
--- a/tests/unittests/test_log.py
+++ b/tests/unittests/test_log.py
@@ -29,6 +29,7 @@ class TestCloudInitLogger(CiTestCase):

     def test_logger_uses_gmtime(self):
         """Test that log message have timestamp in UTC (gmtime)"""
+ assert 0

         # Log a message, extract the timestamp from the log entry
         # convert to datetime, and compare to a utc timestamp before

[Ryan Harper (raharper)]

That looks nifty, what does that look like in practice?

[Ryan Harper (raharper)]

Is the file line number available as well?

[Server Team CI bot (server-team-bot)]

PASSED: Continuous integration, rev:461a98bd8f358ca01412ed2e1347b350087e4c03
https://jenkins.ubuntu.com/server/job/cloud-init-ci/287/
Executed test runs:
    SUCCESS: Checkout
    SUCCESS: Unit & Style Tests
    SUCCESS: Ubuntu LTS: Build
    SUCCESS: Ubuntu LTS: Integration
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/287/rebuild

review: Approve (continuous-integration)

[Scott Moser (smoser)]

review: Approve

diff --git a/cloudinit/tests/helpers.py b/cloudinit/tests/helpers.py
index de24e25..f53ab8f 100644
--- a/cloudinit/tests/helpers.py
+++ b/cloudinit/tests/helpers.py
@@ -14,6 +14,7 @@ import time
 import mock
 import six
 import unittest2
+from unittest2.util import strclass
 
 try:
     from contextlib import ExitStack
@@ -115,6 +116,9 @@ class TestCase(unittest2.TestCase):
         super(TestCase, self).setUp()
         self.reset_global_state()
 
+    def shortDescription(self):
+        return strclass(self.__class__) + '.' + self._testMethodName
+
     def add_patch(self, target, attr, *args, **kwargs):
         """Patches specified target object and sets it as attr on test
         instance also schedules cleanup"""