Merge ~cgrabowski/maas:fix_config_permissions_on_init into maas:master

[Christian Grabowski]

change ownership of /etc/maas to maas:maas

[Diego Mascialino (dmascialino)]

just asking you:

did you check these other changes to permissions of /etc/maas* ?

$ git grep "chown.*etc/maas"

debian/maas-common.postinst: chown -R maas:maas /etc/maas/certificates
utilities/remote-reinstall:ssh_run "chown -R maas:maas /etc/maas"

[MAAS Lander (maas-lander)]

UNIT TESTS
-b fix_config_permissions_on_init lp:~cgrabowski/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: e83caa8b40ad83f73a95049f4cf684b5f80a515b

review: Approve

[Christian Grabowski (cgrabowski)]

> just asking you:
>
> did you check these other changes to permissions of /etc/maas* ?
>
>
> $ git grep "chown.*etc/maas"
>
> debian/maas-common.postinst: chown -R maas:maas /etc/maas/certificates
> utilities/remote-reinstall:ssh_run "chown -R maas:maas /etc/maas"

Yeah I noticed those, and regiond.conf and rackd.conf have root:maas as well, thinking about it, we may want maas:maas instead.

[Adam Collard (adam-collard)]

maas:maas is what it was back in 3.1 - unclear what has caused that to change

[Adam Collard (adam-collard)]

review: Approve

[MAAS Lander (maas-lander)]

UNIT TESTS
-b fix_config_permissions_on_init lp:~cgrabowski/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 0959816712cf85e7897111d9ee3c8faa365dd752

review: Approve

[MAAS Lander (maas-lander)]

UNIT TESTS
-b fix_config_permissions_on_init lp:~cgrabowski/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 67fc2f60d3be45b5b4eafa633dd4331f81f153ea

review: Approve

[MAAS Lander (maas-lander)]

UNIT TESTS
-b fix_config_permissions_on_init lp:~cgrabowski/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: d3a44f73c95a986e5bb44b01fe2c73dccf0f66c1

review: Approve

[MAAS Lander (maas-lander)]

LANDING
-b fix_config_permissions_on_init lp:~cgrabowski/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED BUILD
LOG: http://maas-ci.internal:8080/job/maas-tester/1634/consoleText

diff --git a/debian/maas-common.postinst b/debian/maas-common.postinst
index 67e9787..e01b158 100755
--- a/debian/maas-common.postinst
+++ b/debian/maas-common.postinst
@@ -17,6 +17,10 @@ configure_logging() {
     chown maas:maas /var/log/maas/maas.log
 }
 
+configure_conf_dir() {
+    chown maas:maas /etc/maas
+}
+
 configure_lib_dir() {
     # Ensure lib dir has correct permissions
     chown maas:maas /var/lib/maas/
@@ -42,6 +46,7 @@ add_user_group(){
 disable_nginx
 add_user_group
 configure_logging
+configure_conf_dir
 configure_lib_dir
 
 #DEBHELPER#
diff --git a/debian/maas-rack-controller.postinst b/debian/maas-rack-controller.postinst
index cbd92cd..531ae3b 100755
--- a/debian/maas-rack-controller.postinst
+++ b/debian/maas-rack-controller.postinst
@@ -145,6 +145,7 @@ fix_dns_permissions() {
 # Unconditionally ensure that there is at least an empty configuration
 # file. This does *not* overwrite any existing configuration.
 maas-rack config
+chown maas:maas /etc/maas/rackd.conf
 
 if [ "$1" = "configure" ] && [ -z "$2" ]; then
     configure_logging
diff --git a/debian/maas-region-api.postinst b/debian/maas-region-api.postinst
index 1502dc1..aa0d8b2 100755
--- a/debian/maas-region-api.postinst
+++ b/debian/maas-region-api.postinst
@@ -74,6 +74,7 @@ fix_dns_permissions() {
 # Unconditionally ensure that there is at least an empty configuration
 # file. This does *not* overwrite any existing configuration.
 maas-region local_config_set
+chown maas:maas /etc/maas/regiond.conf
 
 if [ "$1" = "configure" ]; then
     configure_logging