Merge ~cgrabowski/maas:filter_bulk_actions into maas:master

[Christian Grabowski]

add filter and bulk actions to action endpoint

[MAAS Lander (maas-lander)]

UNIT TESTS
-b filter_bulk_actions lp:~cgrabowski/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 3f910aebc21f33cd73455c2375b6786b0e7b3831

review: Approve

[Adam Collard (adam-collard)]

review: Needs Fixing

ad38c6c... by Christian Grabowski on 2022-06-17

simplify unit test for bulk_action

[MAAS Lander (maas-lander)]

UNIT TESTS
-b filter_bulk_actions lp:~cgrabowski/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/12978/console
COMMIT: 6f728636dc7f1e582abcedd273a593b77466ce4d

review: Needs Fixing

[MAAS Lander (maas-lander)]

UNIT TESTS
-b filter_bulk_actions lp:~cgrabowski/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: ad38c6c6a310217367181d33bebd0795b0b147eb

review: Approve

[Alexsander de Souza (alexsander-souza)]

+1

review: Approve

diff --git a/src/maasserver/websockets/handlers/machine.py b/src/maasserver/websockets/handlers/machine.py
index 8c27240..17b557f 100644
--- a/src/maasserver/websockets/handlers/machine.py
+++ b/src/maasserver/websockets/handlers/machine.py
@@ -952,21 +952,41 @@ class MachineHandler(NodeHandler):
                 % (storage_layout, str(e))
             )
 
-    def action(self, params):
-        """Perform the action on the object."""
-        # `compile_node_actions` handles the permission checking internally
-        # the default view permission check is enough at this level.
-        obj = self.get_object(params)
-        action_name = params.get("action")
+    def _action(self, obj, action_name, extra_params):
         actions = compile_node_actions(obj, self.user, request=self.request)
         action = actions.get(action_name)
         if action is None:
             raise NodeActionError(
                 f"{action_name} action is not available for this node."
             )
-        extra_params = params.get("extra", {})
         return action.execute(**extra_params)
 
+    def _bulk_action(self, filter_params, action_name, extra_params):
+        machines = self._filter(self._meta.queryset, None, filter_params)
+        success_count = 0
+        for machine in machines:
+            try:
+                self._action(machine, action_name, extra_params)
+            except NodeActionError as e:
+                log.error(f"Bulk action for {machine.system_id} failed: {e}")
+            else:
+                success_count += 1
+
+        return success_count
+
+    def action(self, params):
+        """Perform the action on the object."""
+        # `compile_node_actions` handles the permission checking internally
+        # the default view permission check is enough at this level.
+        action_name = params.get("action")
+        extra_params = params.get("extra", {})
+        if "filter" in params:
+            return self._bulk_action(
+                params["filter"], action_name, extra_params
+            )
+        obj = self.get_object(params)
+        return self._action(obj, action_name, extra_params)
+
     def _create_link_on_interface(self, interface, params):
         """Create a link on a new interface."""
         mode = params.get("mode", None)
diff --git a/src/maasserver/websockets/handlers/tests/test_machine.py b/src/maasserver/websockets/handlers/tests/test_machine.py
index a3f1a40..1c6d7a8 100644
--- a/src/maasserver/websockets/handlers/tests/test_machine.py
+++ b/src/maasserver/websockets/handlers/tests/test_machine.py
@@ -5790,3 +5790,34 @@ class TestMachineHandlerFilter(MAASServerTestCase):
                 }
             },
         )
+
+    def test_filter_bulk_action(self):
+        user = factory.make_admin()
+        zone1 = factory.make_Zone()
+        zone2 = factory.make_Zone()
+        zone1_machines = [
+            factory.make_Machine(status=NODE_STATUS.READY, zone=zone1)
+            for _ in range(2)
+        ]
+        zone2_machines = [
+            factory.make_Machine(status=NODE_STATUS.READY, zone=zone2)
+            for _ in range(2)
+        ]
+        handler = MachineHandler(user, {}, None)
+        params = {
+            "action": "acquire",
+            "extra": {},
+            "filter": {"zone": zone1},
+        }
+        success_count = handler.action(params)
+        self.assertEqual(
+            len(zone1_machines),
+            success_count,
+        )
+        machines = zone1_machines + zone2_machines
+        for machine in machines:
+            machine.refresh_from_db()
+            if machine.zone == zone1:
+                self.assertEqual(machine.status, NODE_STATUS.ALLOCATED)
+            else:
+                self.assertEqual(machine.status, NODE_STATUS.READY)