OpenERP Community Backports (Server)

Code review comment for lp:~cedric-lebrouster/ocb-server/ocb-7.0-bug-1253052-parent-order

  1. ocb-7.0-bug-1253052-parent-order
  2. Merge into 7.0
Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

This patch breaks the yaml_import tests.

Extract from the logs:

TEST test_ocb70 openerp.tools.yaml_import: 2. Duplicate the parent category and verify that the children have been duplicated too and are below the new parent
ERROR test_ocb70 openerp.tools.yaml_import: AssertionError in Python code : After duplication, previous record must have old childs records only
TEST test_ocb70 openerp.tools.yaml_import: 3. Duplicate the children then reassign them to the new parent (1st method) and check the parent_store structure.
ERROR test_ocb70 openerp.tools.yaml_import: AssertionError in Python code : After duplication, previous record must have old childs records only
TEST test_ocb70 openerp.tools.yaml_import: 4. Duplicate the children then reassign them to the new parent (2nd method) and check the parent_store structure.
ERROR test_ocb70 openerp.tools.yaml_import: AssertionError in Python code : After duplication, previous record must have old childs records only
TEST test_ocb70 openerp.tools.yaml_import: 5. Duplicate the children then reassign them to the new parent (3rd method) and make sure the parent_store structure is still right.
ERROR test_ocb70 openerp.tools.yaml_import: AssertionError in Python code : After duplication, previous record must have old childs records only

Can you please check this, and adapt the tests (which seem to have some assumptions broken by your changes) or fix the code in yaml_import?

review: Needs Fixing (code review, test)

« Back to merge proposal