Merge lp:~cedric-lebrouster/ocb-server/ocb-7.0-bug-1253052-parent-order into lp:ocb-server
Proposed by
Cedric Le Brouster(OpenFire)
Status: | Rejected |
---|---|
Rejected by: | Holger Brunn (Therp) |
Proposed branch: | lp:~cedric-lebrouster/ocb-server/ocb-7.0-bug-1253052-parent-order |
Merge into: | lp:ocb-server |
Diff against target: |
138 lines (+59/-36) 2 files modified
openerp/addons/base/test/base_test.yml (+13/-1) openerp/osv/orm.py (+46/-35) |
To merge this branch: | bzr merge lp:~cedric-lebrouster/ocb-server/ocb-7.0-bug-1253052-parent-order |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Holger Brunn (Therp) | Disapprove | ||
Alexandre Fayolle - camptocamp | code review, test | Approve | |
Review via email: mp+209708@code.launchpad.net |
Description of the change
Fixes parent_left and parent_right recomputation in write/create methods ( bug lp:1253052 )
To post a comment you must log in.
Unmerged revisions
- 5281. By Cedric Le Brouster(OpenFire)
-
[FIX] orm: fix miscalculation of _parent_left and _parent_right in create() method for some special case.
(i.e. when new object parent's _parent_left value is 0) - 5280. By Cedric Le Brouster(OpenFire)
-
Add tests for _parent_order
- 5279. By Cedric Le Brouster(OpenFire)
-
[FIX] orm: wrong parent_left and parent_right recomputation in write/create methods (see bug 1253052)
This patch looks a bit scary at first, mainly because you have to read it closely to convince yourself that it doesn't trigger a recomputation on every write().
#123-133 can be done in one SQL statement I think, given that we touch that code anyway such an optimization wouldn't hurt imho.