Code review comment for lp:~cassidyjames/egtk/egtk-entry-focus-styles

Revision history for this message
Cassidy James Blaede (cassidyjames) wrote :

Yeah it'd probably be best to base off selected bg color. I'm not _as_
familiar with the GTK-specific CSS color stuff, but will mess around with
it. Any suggestions for what to try?
On Jun 12, 2012 4:01 AM, "Fred" <email address hidden> wrote:

> HSL is great way to work with change hue or color intensity.
> It is much easier than RGB or hex triplets.
>
> On Tue, Jun 12, 2012 at 8:32 AM, Daniel Fore <email address hidden>
> wrote:
> > Review: Needs Fixing
> >
> > I think we should try basing the color off the theme selected color
> instead of hardcoding hexes. Also, we should consider changing the inner
> stroke as well to get more of a glow effect.
> >
> > Thoughts?
> > --
> >
> https://code.launchpad.net/~cassidyjames/egtk/egtk-entry-focus-styles/+merge/109775
> > You are subscribed to branch lp:egtk.
>
> --
>
> https://code.launchpad.net/~cassidyjames/egtk/egtk-entry-focus-styles/+merge/109775
> You are the owner of lp:~cassidyjames/egtk/egtk-entry-focus-styles.
>

« Back to merge proposal