Merge lp:~cassidyjames/egtk/egtk-entry-focus-styles into lp:egtk/1.0

Proposed by Cassidy James Blaede
Status: Rejected
Rejected by: Danielle Foré
Proposed branch: lp:~cassidyjames/egtk/egtk-entry-focus-styles
Merge into: lp:egtk/1.0
Diff against target: 17 lines (+7/-0)
1 file modified
gtk-3.0/gtk-widgets.css (+7/-0)
To merge this branch: bzr merge lp:~cassidyjames/egtk/egtk-entry-focus-styles
Reviewer Review Type Date Requested Status
Danielle Foré Needs Fixing
Review via email: mp+109775@code.launchpad.net

Description of the change

Added focus styles to entries. Reused my style from the switch trough. If it makes more sense to combine them, let me know and we can figure out how to best do that.

To post a comment you must log in.
Revision history for this message
Danielle Foré (danrabbit) wrote :

I think we should try basing the color off the theme selected color instead of hardcoding hexes. Also, we should consider changing the inner stroke as well to get more of a glow effect.

Thoughts?

review: Needs Fixing
Revision history for this message
Fred (eldmannen) wrote :

HSL is great way to work with change hue or color intensity.
It is much easier than RGB or hex triplets.

On Tue, Jun 12, 2012 at 8:32 AM, Daniel Fore <email address hidden> wrote:
> Review: Needs Fixing
>
> I think we should try basing the color off the theme selected color instead of hardcoding hexes. Also, we should consider changing the inner stroke as well to get more of a glow effect.
>
> Thoughts?
> --
> https://code.launchpad.net/~cassidyjames/egtk/egtk-entry-focus-styles/+merge/109775
> You are subscribed to branch lp:egtk.

Revision history for this message
Cassidy James Blaede (cassidyjames) wrote :

Yeah it'd probably be best to base off selected bg color. I'm not _as_
familiar with the GTK-specific CSS color stuff, but will mess around with
it. Any suggestions for what to try?
On Jun 12, 2012 4:01 AM, "Fred" <email address hidden> wrote:

> HSL is great way to work with change hue or color intensity.
> It is much easier than RGB or hex triplets.
>
> On Tue, Jun 12, 2012 at 8:32 AM, Daniel Fore <email address hidden>
> wrote:
> > Review: Needs Fixing
> >
> > I think we should try basing the color off the theme selected color
> instead of hardcoding hexes. Also, we should consider changing the inner
> stroke as well to get more of a glow effect.
> >
> > Thoughts?
> > --
> >
> https://code.launchpad.net/~cassidyjames/egtk/egtk-entry-focus-styles/+merge/109775
> > You are subscribed to branch lp:egtk.
>
> --
>
> https://code.launchpad.net/~cassidyjames/egtk/egtk-entry-focus-styles/+merge/109775
> You are the owner of lp:~cassidyjames/egtk/egtk-entry-focus-styles.
>

Revision history for this message
Danielle Foré (danrabbit) wrote :

I didn't look at it tbh xD I looked at the code

Revision history for this message
Cassidy James Blaede (cassidyjames) wrote :

Laaame. Look at the style to see if it's even worth pursuing. ;)
On Jun 12, 2012 8:51 PM, "Daniel Fore" <email address hidden> wrote:

> I didn't look at it tbh xD I looked at the code
> --
>
> https://code.launchpad.net/~cassidyjames/egtk/egtk-entry-focus-styles/+merge/109775
> You are the owner of lp:~cassidyjames/egtk/egtk-entry-focus-styles.
>

Revision history for this message
Danielle Foré (danrabbit) wrote :

marking as rejected since I did a different entry focus branch

Unmerged revisions

502. By Cassidy James Blaede

Added focus styles to the entries.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'gtk-3.0/gtk-widgets.css'
2--- gtk-3.0/gtk-widgets.css 2012-06-12 00:46:41 +0000
3+++ gtk-3.0/gtk-widgets.css 2012-06-12 06:03:22 +0000
4@@ -803,6 +803,13 @@
5 -GtkEntry-progress-border: 0;
6 }
7
8+*.entry:focus {
9+ -unico-border-gradient: -gtk-gradient (linear,
10+ left top, left bottom,
11+ from (#4187b8),
12+ to (#55c1ec));
13+}
14+
15 *.security_trusted {
16
17 color: #0c4d0f;

Subscribers

People subscribed via source and target branches

to all changes: