Code review comment for lp:~carla-sella/ubuntu-filemanager-app/test-places-fixed

Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

=== modified file 'tests/autopilot/filemanager/__init__.py'
--- tests/autopilot/filemanager/__init__.py 2014-11-19 20:24:25 +0000
+++ tests/autopilot/filemanager/__init__.py 2014-11-19 21:23:13 +0000
@@ -71,13 +71,10 @@

     def get_folder_list_page(self):
         """Return the FolderListPage emulator of the MainView."""
- page = self.wait_select_single(FolderListPage)
- page.main_view = self
- return page
+ return self.wait_select_single(FolderListPage)

     def _go_to_place_from_places_page(self, object_name):
         placespage = self.open_places()
- self.placespage.active.wait_for(True)
         placespage.go_to_place(object_name)

     @autopilot.logging.log_action(logger.info)
@@ -107,9 +104,9 @@
             logger.error('BottomEdge element not found.')
             raise

- self.wait_select_single(
- "QQuickFlickable", objectName="placesFlickable")\
- .dragging.wait_for(False)
+ flickable = self.wait_select_single(
+ "QQuickFlickable", objectName="placesFlickable")
+ flickable.wait_until_destroyed()

     @autopilot.logging.log_action(logger.info)
     def rename(self, original_name, new_name):

review: Needs Fixing

« Back to merge proposal