Merge lp:~carla-sella/ubuntu-filemanager-app/test-places-fixed into lp:ubuntu-filemanager-app

[Carla Sella]

Fixed autopilot places tests for filemanager app.

Fixed two tests in test_places.py, but cannot test on device, so I'm proposing merge to see if in Jenkins tests pass.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:326
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/381/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-vivid/99/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-filemanager-app-vivid-amd64-ci/3/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/381/rebuild

review: Needs Fixing (continuous-integration)

[lp:~carla-sella/ubuntu-filemanager-app/test-places-fixed]

327. By Carla Sella on 2014-11-09

Modifies README file.

328. By Carla Sella on 2014-11-09

Fixed pep8 and pyflakes.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:328
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/382/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-vivid/100
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/100/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-vivid-amd64-ci/4

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/382/rebuild

review: Needs Fixing (continuous-integration)

[Carla Sella (carla-sella)]

The error is quite weired as the 'Standard' object with objectName: 'placeHome' exists and so the 'placeDevice', see https://dl.dropboxusercontent.com/u/10083981/Ubuntu%20errors/filemanager-places.png.

[lp:~carla-sella/ubuntu-filemanager-app/test-places-fixed]

329. By Carla Sella on 2014-11-09

Fixed wrong syntax of objectName.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:329
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/383/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-vivid/101
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/101/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-vivid-amd64-ci/5

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/383/rebuild

review: Needs Fixing (continuous-integration)

[lp:~carla-sella/ubuntu-filemanager-app/test-places-fixed]

330. By Carla Sella on 2014-11-09

Trying to verify if error is a timing issue.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:330
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/384/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-vivid/102/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-filemanager-app-vivid-amd64-ci/6/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/384/rebuild

review: Needs Fixing (continuous-integration)

[lp:~carla-sella/ubuntu-filemanager-app/test-places-fixed]

331. By Carla Sella on 2014-11-09

Fixed pep8 error.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:331
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/385/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-vivid/103
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/103/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-vivid-amd64-ci/7

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/385/rebuild

review: Needs Fixing (continuous-integration)

[lp:~carla-sella/ubuntu-filemanager-app/test-places-fixed]

332. By Carla Sella on 2014-11-09

Deleted sleep.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:332
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/386/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-vivid/104
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/104/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-vivid-amd64-ci/8

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/386/rebuild

review: Needs Fixing (continuous-integration)

[lp:~carla-sella/ubuntu-filemanager-app/test-places-fixed]

333. By Carla Sella on 2014-11-09

Fixed test_go_to_root_must_open_the_root_directory.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:333
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/387/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-vivid/106/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-filemanager-app-vivid-amd64-ci/9/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/387/rebuild

review: Needs Fixing (continuous-integration)

[lp:~carla-sella/ubuntu-filemanager-app/test-places-fixed]

334. By Carla Sella on 2014-11-09

Other change to test_go_to_root_must_open_the_root_directory.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:334
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/388/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-vivid/107
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/107/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-vivid-amd64-ci/10

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/388/rebuild

review: Needs Fixing (continuous-integration)

[Nicholas Skaggs (nskaggs)]

The test results look good. You'll have to tweak the test about root to point to "HOME"; including our mocked home when mocked, and actual root when it's not mocked.

filemanager.tests.test_places.PlacesTestCase.test_go_to_root_must_open_the_root_directory

[Nicholas Skaggs (nskaggs)]

A few comments. Overall looks good.

[lp:~carla-sella/ubuntu-filemanager-app/test-places-fixed]

335. By Carla Sella on 2014-11-11

Fixed test_go_to_root_must_open_the_root_directory.

[Carla Sella (carla-sella)]

I managed to test test_go_to_root_must_open_the_root_directory on my device and test passes now, so everything should be fine now.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:335
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/389/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-vivid/156
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/156/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-vivid-amd64-ci/11

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/389/rebuild

review: Needs Fixing (continuous-integration)

[Carla Sella (carla-sella)]

@Nicholas: I do not understand why the test fails with:

MismatchError: After 10.0 seconds test failed: '/' != '/tmp/tmp2tsfl4lb'

as I suppose the root directory is "/" on every device you test, or am I wrong ?

I managed to run this test on my device and the test passes and also on the desktop.

[lp:~carla-sella/ubuntu-filemanager-app/test-places-fixed]

336. By Carla Sella on 2014-11-12

Fixed timing issue.

337. By Carla Sella on 2014-11-12

Fixed syntax error.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:336
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/391/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-vivid/181
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/181/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-vivid-amd64-ci/13

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/391/rebuild

review: Needs Fixing (continuous-integration)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:337
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/392/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-vivid/184
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/184/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-vivid-amd64-ci/14

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/392/rebuild

review: Needs Fixing (continuous-integration)

[lp:~carla-sella/ubuntu-filemanager-app/test-places-fixed]

338. By Carla Sella on 2014-11-13

Fixed timing issue.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:338
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/393/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-vivid/208
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/208/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-vivid-amd64-ci/15

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/393/rebuild

review: Needs Fixing (continuous-integration)

[lp:~carla-sella/ubuntu-filemanager-app/test-places-fixed]

339. By Carla Sella on 2014-11-13

Ajusted minor thing.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:339
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/394/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-vivid/209
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/209/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-vivid-amd64-ci/16

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/394/rebuild

review: Needs Fixing (continuous-integration)

[lp:~carla-sella/ubuntu-filemanager-app/test-places-fixed]

340. By Carla Sella on 2014-11-13

Fixed self error.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:340
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/395/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-vivid/210
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/210/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-vivid-amd64-ci/17

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/395/rebuild

review: Needs Fixing (continuous-integration)

[Carla Sella (carla-sella)]

@Nicholas,this time I do not understand the failure, even the video doesn't help.

[Nicholas Skaggs (nskaggs)]

Carla, the error looks the same (a little better, but the same). The page is still not quite loaded, so clicking 'devices' is not registered.

[Nicholas Skaggs (nskaggs)]

Left some comments

[lp:~carla-sella/ubuntu-filemanager-app/test-places-fixed]

341. By Carla Sella on 2014-11-14

Trying other property for Places Page.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:341
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/397/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-vivid/219
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/219/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-vivid-amd64-ci/19

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/397/rebuild

review: Approve (continuous-integration)

[Carla Sella (carla-sella)]

Hey Nicholas, looks like I found the right property to use :-).

[Nicholas Skaggs (nskaggs)]

Awesome! I will happily approve and merge this! But I would still move the code to the open bottom edge method so it gets run by anyone who calls it. Make sense? I'd move

+ placespage.wait_select_single(
339 + "QQuickFlickable", objectName="placesFlickable")\
340 + .dragging.wait_for(False)

to the end of

_drag_bottomedge_to_open_places()

review: Needs Fixing

[Carla Sella (carla-sella)]

Yes it makes sense, but If I put it there it fails with a StateNotFoundError.
That's quite weird as it should not make a big difference putting it at the end of _drag_bottomedge_to_open_places() compared to where it's now, but it fails :(.
Maybe it's another timing issue.

http://paste.ubuntu.com/9027177/

[Carla Sella (carla-sella)]

I have tried testing several properties of Places Page and QQuickFlickable ("placesFlickable") but I keep on getting test failures this is the last try: https://code.launchpad.net/~carla-sella/junk/filemanager-try with this output when ran on my device: http://paste.ubuntu.com/9046535/.
It's as if the test fails before the Places page completly loads.

[Nicholas Skaggs (nskaggs)]

Mmm, let's wrap this up on IRC. Should be a simple solution as what you have in rev 341 works.

review: Needs Fixing

[lp:~carla-sella/ubuntu-filemanager-app/test-places-fixed]

342. By Carla Sella on 2014-11-18

For checking if in Jenkins test works.

343. By Carla Sella on 2014-11-18

Fixed syntax error.

[Carla Sella (carla-sella)]

Nicholas: the test runs fine now on my PC and on device.
So if it passes on Jenkins it should be ok.
For the -p in launch_test_local should that be deleted or kept ?

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:343
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/398/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-vivid/263
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/263/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-vivid-amd64-ci/20

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/398/rebuild

review: Needs Fixing (continuous-integration)

[Nicholas Skaggs (nskaggs)]

Leave the phone mode for now; I'll file a bug right now so I don't forget so support is added for both:

https://bugs.launchpad.net/ubuntu-filemanager-app/+bug/1393973

Looks like in jenkins it's still suffering a bit from the timing issue; the page isn't quite loaded while it's trying to tap.

review: Needs Fixing

[lp:~carla-sella/ubuntu-filemanager-app/test-places-fixed]

344. By Carla Sella on 2014-11-19

Added wait for active property to be true on Places Page.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:344
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/399/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-vivid/320
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/320/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-vivid-amd64-ci/21

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/399/rebuild

review: Needs Fixing (continuous-integration)

[lp:~carla-sella/ubuntu-filemanager-app/test-places-fixed]

345. By Carla Sella on 2014-11-19

Fixed error in code.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:345
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/400/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-vivid/321
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/321/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-vivid-amd64-ci/22

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/400/rebuild

review: Needs Fixing (continuous-integration)

[lp:~carla-sella/ubuntu-filemanager-app/test-places-fixed]

346. By Carla Sella on 2014-11-19

Deleted erroneous self.

[Nicholas Skaggs (nskaggs)]

=== modified file 'tests/autopilot/filemanager/__init__.py'
--- tests/autopilot/filemanager/__init__.py 2014-11-19 20:24:25 +0000
+++ tests/autopilot/filemanager/__init__.py 2014-11-19 21:23:13 +0000
@@ -71,13 +71,10 @@

     def get_folder_list_page(self):
         """Return the FolderListPage emulator of the MainView."""
- page = self.wait_select_single(FolderListPage)
- page.main_view = self
- return page
+ return self.wait_select_single(FolderListPage)

     def _go_to_place_from_places_page(self, object_name):
         placespage = self.open_places()
- self.placespage.active.wait_for(True)
         placespage.go_to_place(object_name)

     @autopilot.logging.log_action(logger.info)
@@ -107,9 +104,9 @@
             logger.error('BottomEdge element not found.')
             raise

- self.wait_select_single(
- "QQuickFlickable", objectName="placesFlickable")\
- .dragging.wait_for(False)
+ flickable = self.wait_select_single(
+ "QQuickFlickable", objectName="placesFlickable")
+ flickable.wait_until_destroyed()

     @autopilot.logging.log_action(logger.info)
     def rename(self, original_name, new_name):

review: Needs Fixing

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:346
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/401/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-vivid/322
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/322/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-vivid-amd64-ci/23

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/401/rebuild

review: Needs Fixing (continuous-integration)

[lp:~carla-sella/ubuntu-filemanager-app/test-places-fixed]

347. By Carla Sella on 2014-11-19

Checked for flickable to be destroyed.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:347
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/402/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-vivid/323
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/323/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-vivid-amd64-ci/24

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/402/rebuild

review: Approve (continuous-integration)

=== modified file 'README'
--- README	2014-08-09 19:16:02 +0000
+++ README	2014-11-19 21:30:40 +0000
@@ -27,7 +27,7 @@
    password
 4. Once created, you'll need to add the build dependencies for the app:
   - Click on the Maintain button on your chroot
-  - On the terminal prompt that is started, type 
+  - On the terminal prompt that is started, type
     apt-get install libtag1-dev:armhf libpam0g-dev:armhf python3
   - Close the terminal when the installation finishes
 5. Now you can either do a clean checkout and wait to be prompted by Qt Creator
@@ -56,11 +56,17 @@
 
 No additional steps are required before running the app on the desktop.
 
+You can pass two switches to run in phone or tablet mode from the desktop:
+
+-p for phone mode
+-t for tablet mode
+
+
 ### On a device
 
 Due to Qt Creator's bug #1312094 in launchpad.net, there needs to be a manual
 workaround done before the app can run on the device:
- 
+
 1. Modify the desktop.in file: change the Exec line to read:
    Exec=lib/arm-linux-gnueabihf/bin/@EXEC@
 
@@ -147,5 +153,17 @@
 Once the app has been built, you can go to the build directory and run:
 
     cd tests/autopilot
-    autopilot run filemanager
+    autopilot3 run filemanager
+
+You can run filemanager in phone or tablet mode passing one of these two switches:
+
+-p for phone mode
+-t for tablet mode
+
+so:
+
+autopilot3 launch ../../src/app/filemanager -p
+
+will launch filemanager with autopilot in phone mode.
+
 

=== modified file 'po/com.ubuntu.filemanager.pot'
--- po/com.ubuntu.filemanager.pot	2014-10-25 00:00:57 +0000
+++ po/com.ubuntu.filemanager.pot	2014-11-19 21:30:40 +0000
@@ -8,7 +8,7 @@
 msgstr ""
 "Project-Id-Version: \n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2014-10-24 16:57-0700\n"
+"POT-Creation-Date: 2014-11-19 21:32+0100\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language-Team: LANGUAGE <[e-mail]>\n"
@@ -31,7 +31,7 @@
 msgstr ""
 
 #: ../src/app/qml/components/PathHistoryRow.qml:84
-#: ../src/app/qml/ui/FolderListPage.qml:617
+#: ../src/app/qml/ui/FolderListPage.qml:620
 msgid "Device"
 msgstr ""
 
@@ -44,21 +44,21 @@
 msgid "Open with"
 msgstr ""
 
-#: ../src/app/qml/filemanager.qml:90 ../src/app/qml/ui/FolderListPage.qml:102
+#: ../src/app/qml/filemanager.qml:81 ../src/app/qml/ui/FolderListPage.qml:102
 #: ../src/app/qml/ui/SettingsSheet.qml:31
 msgid "Settings"
 msgstr ""
 
-#: ../src/app/qml/filemanager.qml:91
+#: ../src/app/qml/filemanager.qml:82
 msgid "Change app settings"
 msgstr ""
 
-#: ../src/app/qml/filemanager.qml:268 ../src/app/qml/ui/FolderListPage.qml:349
+#: ../src/app/qml/filemanager.qml:259 ../src/app/qml/ui/FolderListPage.qml:352
 #: ../src/app/qml/ui/ViewPopover.qml:70
 msgid "Icons"
 msgstr ""
 
-#: ../src/app/qml/filemanager.qml:268 ../src/app/qml/ui/FolderListPage.qml:365
+#: ../src/app/qml/filemanager.qml:259 ../src/app/qml/ui/FolderListPage.qml:368
 #: ../src/app/qml/ui/ViewPopover.qml:71
 msgid "List"
 msgstr ""
@@ -68,7 +68,7 @@
 msgstr ""
 
 #: ../src/app/qml/ui/AuthenticationDialog.qml:27
-msgid "Enter password:"
+msgid "Password is required to access all files"
 msgstr ""
 
 #: ../src/app/qml/ui/AuthenticationDialog.qml:39
@@ -87,7 +87,7 @@
 #: ../src/app/qml/ui/ConfirmDialogWithInput.qml:57
 #: ../src/app/qml/ui/FileActionDialog.qml:45
 #: ../src/app/qml/ui/FileOperationProgressDialog.qml:44
-#: ../src/app/qml/ui/FolderListPage.qml:304
+#: ../src/app/qml/ui/FolderListPage.qml:330
 #: ../src/app/qml/ui/GoToDialog.qml:66
 msgid "Cancel"
 msgstr ""
@@ -166,7 +166,7 @@
 
 #: ../src/app/qml/ui/FolderListPage.qml:74
 #: ../src/app/qml/ui/FolderListPage.qml:92
-#: ../src/app/qml/ui/FolderListPage.qml:508
+#: ../src/app/qml/ui/FolderListPage.qml:511
 msgid "Properties"
 msgstr ""
 
@@ -178,118 +178,122 @@
 msgid "Go To"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:176
+#: ../src/app/qml/ui/FolderListPage.qml:116
+msgid "Unlock full access"
+msgstr ""
+
+#: ../src/app/qml/ui/FolderListPage.qml:130
+msgid "Authentication failed"
+msgstr ""
+
+#: ../src/app/qml/ui/FolderListPage.qml:202
 #, qt-format
 msgid "%1 file"
 msgid_plural "%1 files"
 msgstr[0] ""
 msgstr[1] ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:201
+#: ../src/app/qml/ui/FolderListPage.qml:227
 msgid "Open in a new tab"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:209
+#: ../src/app/qml/ui/FolderListPage.qml:235
 msgid "Close this tab"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:222
+#: ../src/app/qml/ui/FolderListPage.qml:248
 msgid "Create folder"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:223
+#: ../src/app/qml/ui/FolderListPage.qml:249
 msgid "Enter name for new folder"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:239
+#: ../src/app/qml/ui/FolderListPage.qml:265
 msgid "Create file"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:240
+#: ../src/app/qml/ui/FolderListPage.qml:266
 msgid "Enter name for new file"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:289
+#: ../src/app/qml/ui/FolderListPage.qml:315
 msgid "Select"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:312
-msgid "Unlock full access"
-msgstr ""
-
-#: ../src/app/qml/ui/FolderListPage.qml:326
-msgid "Authentication failed"
-msgstr ""
-
-#: ../src/app/qml/ui/FolderListPage.qml:380
+#: ../src/app/qml/ui/FolderListPage.qml:383
 msgid "No files"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:400
-#: ../src/app/qml/ui/FolderListPage.qml:482
+#: ../src/app/qml/ui/FolderListPage.qml:403
+#: ../src/app/qml/ui/FolderListPage.qml:485
 msgid "Delete"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:401
+#: ../src/app/qml/ui/FolderListPage.qml:404
 #, qt-format
 msgid "Are you sure you want to permanently delete '%1'?"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:424
-#: ../src/app/qml/ui/FolderListPage.qml:495
+#: ../src/app/qml/ui/FolderListPage.qml:409
+msgid "Deleting files"
+msgstr ""
+
+#: ../src/app/qml/ui/FolderListPage.qml:427
+#: ../src/app/qml/ui/FolderListPage.qml:498
 msgid "Rename"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:425
+#: ../src/app/qml/ui/FolderListPage.qml:428
 msgid "Enter a new name"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:434
+#: ../src/app/qml/ui/FolderListPage.qml:437
 msgid "Could not rename"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:435
+#: ../src/app/qml/ui/FolderListPage.qml:438
 msgid "Insufficient permissions or name already exists?"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:459
+#: ../src/app/qml/ui/FolderListPage.qml:462
 msgid "Cut"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:470
+#: ../src/app/qml/ui/FolderListPage.qml:473
 msgid "Copy"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:528
+#: ../src/app/qml/ui/FolderListPage.qml:531
 msgid "File operation error"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:588
+#: ../src/app/qml/ui/FolderListPage.qml:591
 msgid "~/Desktop"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:598
+#: ../src/app/qml/ui/FolderListPage.qml:601
 msgid "~/Public"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:600
+#: ../src/app/qml/ui/FolderListPage.qml:603
 msgid "~/Programs"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:602
+#: ../src/app/qml/ui/FolderListPage.qml:605
 msgid "~/Templates"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:615
+#: ../src/app/qml/ui/FolderListPage.qml:618
 msgid "Home"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:685
+#: ../src/app/qml/ui/FolderListPage.qml:688
 msgid "Folder not accessible"
 msgstr ""
 
 #. TRANSLATORS: this refers to a folder name
-#: ../src/app/qml/ui/FolderListPage.qml:687
+#: ../src/app/qml/ui/FolderListPage.qml:690
 #, qt-format
 msgid "Can not access %1"
 msgstr ""
@@ -302,12 +306,12 @@
 msgid "Enter a location to go to:"
 msgstr ""
 
-#: ../src/app/qml/ui/GoToDialog.qml:44 ../src/app/qml/ui/PlacesPage.qml:59
+#: ../src/app/qml/ui/GoToDialog.qml:44 ../src/app/qml/ui/PlacesPage.qml:62
 #: ../src/app/qml/ui/PlacesPopover.qml:67
 msgid "Location..."
 msgstr ""
 
-#: ../src/app/qml/ui/GoToDialog.qml:53 ../src/app/qml/ui/PlacesPage.qml:74
+#: ../src/app/qml/ui/GoToDialog.qml:53 ../src/app/qml/ui/PlacesPage.qml:77
 #: ../src/app/qml/ui/PlacesPopover.qml:82
 msgid "Go"
 msgstr ""

=== modified file 'src/app/qml/ui/PlacesPage.qml'
--- src/app/qml/ui/PlacesPage.qml	2014-10-21 18:57:13 +0000
+++ src/app/qml/ui/PlacesPage.qml	2014-11-19 21:30:40 +0000
@@ -27,8 +27,11 @@
 
     title: i18n.tr("Places")
     objectName: 'PlacesPage'
+    // ADDED THIS PROPERTY FOR BUG #1341671  WORKAROUND
+    property string testProperty: "justForAutopilotTests"
 
     Flickable {
+        objectName: "placesFlickable"
         anchors.fill: parent
 
         Column {

=== modified file 'tests/autopilot/filemanager/__init__.py'
--- tests/autopilot/filemanager/__init__.py	2014-10-24 14:25:32 +0000
+++ tests/autopilot/filemanager/__init__.py	2014-11-19 21:30:40 +0000
@@ -63,7 +63,7 @@
         if self.showSidebar:
             self._go_to_place_from_side_bar(object_name)
         else:
-            self._go_to_place_from_popover(object_name)
+            self._go_to_place_from_places_page(object_name)
 
     def _go_to_place_from_side_bar(self, object_name):
         side_bar = self.get_folder_list_page().get_sidebar()
@@ -75,27 +75,40 @@
         page.main_view = self
         return page
 
-    def _go_to_place_from_popover(self, object_name):
-        popover = self.open_places()
-        place = popover.wait_select_single('Standard', objectName=object_name)
-        self.pointing_device.click_object(place)
+    def _go_to_place_from_places_page(self, object_name):
+        placespage = self.open_places()
+        placespage.go_to_place(object_name)
 
     @autopilot.logging.log_action(logger.info)
     def open_places(self):
         if not self.showSidebar:
-            self.open_toolbar().click_button('places')
-            return self._get_places_popover()
+            self._drag_bottomedge_to_open_places()
+            return self.wait_select_single(PlacesPage)
         else:
             raise FilemanagerException(
-                'The places popover cannot be opened on wide mode.')
-
-    def _get_places_popover(self):
-        """Return the Places popover."""
-        # XXX It would be easier if the places popover was an object
-        # that inherits from Popover, like the
-        # ActionSelectionPopover does.
-        # --elopio - 2013-07-25
-        return self.wait_select_single('Popover', objectName='placesPopover')
+                'The places page cannot be opened on wide mode.')
+
+    def _drag_bottomedge_to_open_places(self):
+        """Bring the places page to the screen"""
+        try:
+            action_item = self.wait_select_single(
+                'ShapeItem', objectName='bottomEdgeTip')
+            action_item.enabled.wait_for(True)
+            start_x = (action_item.globalRect.x +
+                       (action_item.globalRect.width * 0.5))
+            start_y = (action_item.globalRect.y +
+                       (action_item.height * 0.5))
+            stop_y = start_y - (self.height * 0.7)
+            self.pointing_device.drag(start_x, start_y,
+                                      start_x, stop_y, rate=2)
+
+        except dbus.StateNotFoundError:
+            logger.error('BottomEdge element not found.')
+            raise
+
+        flickable = self.wait_select_single(
+            "QQuickFlickable", objectName="placesFlickable")
+        flickable.wait_until_destroyed()
 
     @autopilot.logging.log_action(logger.info)
     def rename(self, original_name, new_name):
@@ -316,6 +329,14 @@
                 'Path bar is hidden in small mode.')
 
 
+class PlacesPage(ubuntuuitoolkit.UbuntuUIToolkitCustomProxyObjectBase):
+    """Places Page Autopilot emulator."""
+
+    def go_to_place(self, object_name):
+        place = self.wait_select_single('Standard', objectName=object_name)
+        self.pointing_device.click_object(place)
+
+
 class FolderListView(ubuntuuitoolkit.UbuntuUIToolkitCustomProxyObjectBase):
     """FolderListView Autopilot emulator."""
 

=== modified file 'tests/autopilot/filemanager/tests/__init__.py'
--- tests/autopilot/filemanager/tests/__init__.py	2014-10-10 22:29:32 +0000
+++ tests/autopilot/filemanager/tests/__init__.py	2014-11-19 21:30:40 +0000
@@ -84,6 +84,7 @@
                                                       'src', 'plugin')))
         return self.launch_test_application(
             self.local_location_binary,
+            '-p',
             '-q', self.local_location_qml,
             app_type='qt',
             emulator_base=ubuntuuitoolkit.UbuntuUIToolkitCustomProxyObjectBase)

=== modified file 'tests/autopilot/filemanager/tests/test_places.py'
--- tests/autopilot/filemanager/tests/test_places.py	2014-10-25 01:21:48 +0000
+++ tests/autopilot/filemanager/tests/test_places.py	2014-11-19 21:30:40 +0000
@@ -25,24 +25,18 @@
 
     def test_go_home_must_open_the_home_directory(self):
         """Test that opens the Home bookmark from the places section."""
-        # TODO: there is no support for bottom edge folder list yet, so
-        # for now disable it
-        if self.app.main_view.showSidebar:
-            self.app.main_view.go_to_place('placeHome')
+        self.app.main_view.go_to_place('placeHome')
 
-            folder_list_page = self.app.main_view.get_folder_list_page()
-            self.assertThat(
-                folder_list_page.get_current_path,
-                Eventually(Equals(self.fakehome)))
+        folder_list_page = self.app.main_view.get_folder_list_page()
+        self.assertThat(
+            folder_list_page.get_current_path,
+            Eventually(Equals(self.fakehome)))
 
     def test_go_to_root_must_open_the_root_directory(self):
         """Test that opens the Device bookmark from the places section."""
-        # TODO: there is no support for bottom edge folder list yet, so
-        # for now disable it
-        if self.app.main_view.showSidebar:
-            self.app.main_view.go_to_place('placeDevice')
+        self.app.main_view.go_to_place('placeDevice')
 
-            folder_list_page = self.app.main_view.get_folder_list_page()
-            self.assertThat(
-                folder_list_page.get_current_path,
-                Eventually(Equals('/')))
+        folder_list_page = self.app.main_view.get_folder_list_page()
+        self.assertThat(
+            folder_list_page.get_current_path,
+            Eventually(Equals('/')))