Code review comment for lp:~canonical-isd-hackers/wordpress-launchpad-integration/ubuntu-sso

Revision history for this message
Stuart Metcalfe (stuartmetcalfe) wrote :

We discussed removing the hyphen from "Sign-On". Also, changing the constant name from LAUNCHPAD_SSO to UBUNTU_SSO but this will require more significant changes so we should hold off on this until we have better test coverage and more time. I notice the first change has already been done, and there's current no unit-test suite to build on, so this merge is approved.

review: Approve

« Back to merge proposal