Merge lp:~canonical-isd-hackers/wordpress-launchpad-integration/ubuntu-sso into lp:wordpress-launchpad-integration
Proposed by
Szilveszter Farkas
Status: | Merged |
---|---|
Approved by: | Stuart Metcalfe |
Approved revision: | 21 |
Merged at revision: | 19 |
Proposed branch: | lp:~canonical-isd-hackers/wordpress-launchpad-integration/ubuntu-sso |
Merge into: | lp:wordpress-launchpad-integration |
Diff against target: |
63 lines (+17/-5) 2 files modified
launchpad_login.php (+7/-1) openid-launchpad.php (+10/-4) |
To merge this branch: | bzr merge lp:~canonical-isd-hackers/wordpress-launchpad-integration/ubuntu-sso |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Stuart Metcalfe (community) | Approve | ||
Review via email: mp+24127@code.launchpad.net |
Description of the change
This branch adds the Ubuntu SSO service as an option to use for authentication.
To post a comment you must log in.
We discussed removing the hyphen from "Sign-On". Also, changing the constant name from LAUNCHPAD_SSO to UBUNTU_SSO but this will require more significant changes so we should hold off on this until we have better test coverage and more time. I notice the first change has already been done, and there's current no unit-test suite to build on, so this merge is approved.