Merge lp:~camptocamp/stock-logistic-warehouse/7.0-improve_stock_location_ownership-afe into lp:stock-logistic-warehouse

Proposed by Alexandre Fayolle - camptocamp
Status: Needs review
Proposed branch: lp:~camptocamp/stock-logistic-warehouse/7.0-improve_stock_location_ownership-afe
Merge into: lp:stock-logistic-warehouse
Diff against target: 126 lines (+100/-1)
4 files modified
stock_location_ownership/__openerp__.py (+7/-1)
stock_location_ownership/i18n/en.po (+31/-0)
stock_location_ownership/i18n/fr.po (+31/-0)
stock_location_ownership/i18n/stock_location_ownership.pot (+31/-0)
To merge this branch: bzr merge lp:~camptocamp/stock-logistic-warehouse/7.0-improve_stock_location_ownership-afe
Reviewer Review Type Date Requested Status
Alexandre Fayolle - camptocamp Needs Resubmitting
Ana Juaristi Olalde (community) Approve
Sandy Carter (http://www.savoirfairelinux.com) grammar Needs Fixing
Pedro Manuel Baeza code review Approve
Yannick Vaucher @ Camptocamp Approve
Review via email: mp+210859@code.launchpad.net

Description of the change

stock_location_ownership: add missing pot file, improve module description.

To post a comment you must log in.
Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

Thanks LGTM

review: Approve
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Thank you very much for expand the description!

Regards.

review: Approve (code review)
Revision history for this message
Sandy Carter (http://www.savoirfairelinux.com) (sandy-carter) wrote :

Grammar mistakes in the description

l.11 instances should be plural
This is useful for instance
This is useful for instances

l.12 comma after case
In which case a possible workflow
In which case, a possible workflow

l.12 run on sentence, consider breaking into two
In which case, a possible workflow
could be that the company is allowed to use that stock, but this would generate
a purchase order for the real owner of the stock, with or without direct
delivery.
In which case, a possible workflow
could be that the company is allowed to use that stock. This would generate
a purchase order for the real owner of the stock, with or without direct
delivery.

review: Needs Fixing (grammar)
Revision history for this message
Ana Juaristi Olalde (ajuaristio) wrote :

Thanks LGTM

review: Approve
Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

The source code management for this project has been moved to https://github.com/OCA/stock-logistics-warehouse

Could you resubmit this MP on the new site?

review: Needs Resubmitting

Unmerged revisions

36. By Alexandre Fayolle - camptocamp

[IMP] stock_location_ownership: improve addon description

35. By Alexandre Fayolle - camptocamp

[IMP] stock_location_ownership: add pot file and french translation

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'stock_location_ownership/__openerp__.py'
--- stock_location_ownership/__openerp__.py 2013-08-06 15:07:18 +0000
+++ stock_location_ownership/__openerp__.py 2014-03-13 16:59:31 +0000
@@ -31,7 +31,13 @@
31Stock Location Ownership31Stock Location Ownership
32========================32========================
3333
34Adds an ownership on the stock locations34Adds an ownership on the stock locations.
35
36This is useful for instance when some locations in a warehouse are used to hold
37products which do not belong to the company. In which case a possible workflow
38could be that the company is allowed to use that stock, but this would generate
39a purchase order for the real owner of the stock, with or without direct
40delivery.
35""",41""",
36 'depends': ['stock',42 'depends': ['stock',
37 ],43 ],
3844
=== added file 'stock_location_ownership/i18n/en.po'
--- stock_location_ownership/i18n/en.po 1970-01-01 00:00:00 +0000
+++ stock_location_ownership/i18n/en.po 2014-03-13 16:59:31 +0000
@@ -0,0 +1,31 @@
1# Translation of OpenERP Server.
2# This file contains the translation of the following modules:
3#
4msgid ""
5msgstr ""
6"Project-Id-Version: OpenERP Server 7.0\n"
7"Report-Msgid-Bugs-To: \n"
8"POT-Creation-Date: 2014-03-13 16:49+0000\n"
9"PO-Revision-Date: 2014-03-13 16:44+0000\n"
10"Last-Translator: <>\n"
11"Language-Team: \n"
12"Language: \n"
13"MIME-Version: 1.0\n"
14"Content-Type: text/plain; charset=UTF-8\n"
15"Content-Transfer-Encoding: \n"
16"Plural-Forms: \n"
17
18#. module: stock_location_ownership
19#: field:stock.location,owner_id:0
20msgid "Owner"
21msgstr "Owner"
22
23#. module: stock_location_ownership
24#: help:stock.location,owner_id:0
25msgid "Owner of the location if different from the company or address."
26msgstr "Owner of the location if different from the company or address."
27
28#. module: stock_location_ownership
29#: model:ir.model,name:stock_location_ownership.model_stock_location
30msgid "Location"
31msgstr "Location"
032
=== added file 'stock_location_ownership/i18n/fr.po'
--- stock_location_ownership/i18n/fr.po 1970-01-01 00:00:00 +0000
+++ stock_location_ownership/i18n/fr.po 2014-03-13 16:59:31 +0000
@@ -0,0 +1,31 @@
1# Translation of OpenERP Server.
2# This file contains the translation of the following modules:
3#
4msgid ""
5msgstr ""
6"Project-Id-Version: OpenERP Server 7.0\n"
7"Report-Msgid-Bugs-To: \n"
8"POT-Creation-Date: 2014-03-13 16:49+0000\n"
9"PO-Revision-Date: 2014-03-13 17:51+0100\n"
10"Last-Translator: <>\n"
11"Language-Team: \n"
12"Language: \n"
13"MIME-Version: 1.0\n"
14"Content-Type: text/plain; charset=UTF-8\n"
15"Content-Transfer-Encoding: \n"
16"Plural-Forms: \n"
17
18#. module: stock_location_ownership
19#: field:stock.location,owner_id:0
20msgid "Owner"
21msgstr "Propriétaire"
22
23#. module: stock_location_ownership
24#: help:stock.location,owner_id:0
25msgid "Owner of the location if different from the company or address."
26msgstr "Propriétaire de l'emplacement, si différent de la société"
27
28#. module: stock_location_ownership
29#: model:ir.model,name:stock_location_ownership.model_stock_location
30msgid "Location"
31msgstr "Emplacement"
032
=== added file 'stock_location_ownership/i18n/stock_location_ownership.pot'
--- stock_location_ownership/i18n/stock_location_ownership.pot 1970-01-01 00:00:00 +0000
+++ stock_location_ownership/i18n/stock_location_ownership.pot 2014-03-13 16:59:31 +0000
@@ -0,0 +1,31 @@
1# Translation of OpenERP Server.
2# This file contains the translation of the following modules:
3#
4msgid ""
5msgstr ""
6"Project-Id-Version: OpenERP Server 7.0\n"
7"Report-Msgid-Bugs-To: \n"
8"POT-Creation-Date: 2014-03-13 16:49+0000\n"
9"PO-Revision-Date: 2014-03-13 17:50+0100\n"
10"Last-Translator: <>\n"
11"Language-Team: \n"
12"Language: \n"
13"MIME-Version: 1.0\n"
14"Content-Type: text/plain; charset=UTF-8\n"
15"Content-Transfer-Encoding: \n"
16"Plural-Forms: \n"
17
18#. module: stock_location_ownership
19#: field:stock.location,owner_id:0
20msgid "Owner"
21msgstr ""
22
23#. module: stock_location_ownership
24#: help:stock.location,owner_id:0
25msgid "Owner of the location if different from the company or address."
26msgstr ""
27
28#. module: stock_location_ownership
29#: model:ir.model,name:stock_location_ownership.model_stock_location
30msgid "Location"
31msgstr ""

Subscribers

People subscribed via source and target branches