Code review comment for lp:~camptocamp/openerp-rma/7.0-crm_claim_rma_auto_set_warranty-rde

Revision history for this message
Benoit Guillot - http://www.akretion.com (benoit-guillot-z) wrote :

Hello Romain,

I have tested it, it works fine.

Thank you!

One thing, we can maybe put the method _auto_set_warranty() in the model of claim lines and don't use it as a private method ?
=> def auto_set_warranty(self, cr, uid, ids, context):

So it can be call from somthing else (a button for instance).

I'm not sure it is useful but I share my thought :)

What do you think ?

review: Approve

« Back to merge proposal