Merge lp:~camptocamp/openerp-rma/7.0-crm_claim_rma_auto_set_warranty-rde into lp:~openerprma/openerp-rma/7.0

[Romain Deheele - Camptocamp]

Hello,

It adds a _auto_set_warranty function.
For each claim line, if the user has not pressed himself on 'calculate warranty state', it sets warranties automatically for him.

Regards,

Romain

[Benoit Guillot - http://www.akretion.com (benoit-guillot-z)]

Hello Romain,

I have tested it, it works fine.

Thank you!

One thing, we can maybe put the method _auto_set_warranty() in the model of claim lines and don't use it as a private method ?
=> def auto_set_warranty(self, cr, uid, ids, context):

So it can be call from somthing else (a button for instance).

I'm not sure it is useful but I share my thought :)

What do you think ?

review: Approve

[lp:~camptocamp/openerp-rma/7.0-crm_claim_rma_auto_set_warranty-rde]

80. By Romain Deheele - Camptocamp on 2014-05-12

[UPD] move auto_set_warranty method on claim.line model as suggested by Benoit Guillot

[Romain Deheele - Camptocamp (romaindeheele)]

Hi Benoit,

I'm 100% ok with you, I changed it.

Thanks for the suggestion.

Romain

[Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c)]

review: Approve (code review, no tests)

[Leonardo Pistone (lepistone)]

ok, thanks

review: Approve (code review)

[Lionel Sausin - Initiatives/Numérigraphe (ls-initiatives)]

Looks good from code point of view, not tested because I don't use this module.
Now for the nitpicking:
- multiline docstrings should have the short description on the first line, and the details in the following lines. This lets IDEs show the first line as a quick help.
- please don't initialize the context if you don't use it - it's ok to pass None to other methods.

review: Needs Fixing (nitpicking)

[lp:~camptocamp/openerp-rma/7.0-crm_claim_rma_auto_set_warranty-rde]

81. By Romain Deheele - Camptocamp on 2014-05-16

[UPD] commit nits

[Romain Deheele - Camptocamp (romaindeheele)]

Thanks Lionel, I updated it.

[Lionel Sausin - Initiatives/Numérigraphe (ls-initiatives)]

review: Approve (code review, not test)

=== modified file 'crm_claim_rma/crm_claim_rma.py'
--- crm_claim_rma/crm_claim_rma.py	2014-04-23 07:07:52 +0000
+++ crm_claim_rma/crm_claim_rma.py	2014-05-16 12:29:24 +0000
@@ -254,6 +254,15 @@
             context=context)
         return True
 
+    def auto_set_warranty(self, cr, uid, ids, context):
+        """ Set warranty automatically
+        if the user has not himself pressed on 'Calculate warranty state'
+        button, it sets warranty for him"""
+        for line in self.browse(cr, uid, ids, context=context):
+            if not line.warning:
+                self.set_warranty(cr, uid, [line.id], context=context)
+        return True
+
     def get_destination_location(self, cr, uid, product_id,
                                  warehouse_id, context=None):
         """Compute and return the destination location ID to take

=== modified file 'crm_claim_rma/wizard/claim_make_picking.py'
--- crm_claim_rma/wizard/claim_make_picking.py	2014-04-08 19:41:50 +0000
+++ crm_claim_rma/wizard/claim_make_picking.py	2014-05-16 12:29:24 +0000
@@ -194,6 +194,9 @@
                     _('A product return cannot be created for various '
                       'destination locations, please choose line with a '
                       'same destination location.'))
+            self.pool.get('claim.line').auto_set_warranty(cr, uid,
+                                                          line_ids,
+                                                          context=context)
             common_dest_partner_id = self._get_common_partner_from_line(
                 cr, uid, line_ids, context=context)
             if not common_dest_partner_id: