Code review comment for lp:~camptocamp/c2c-addons/accounting-profiles

Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

Totally agree with your idea of creating profiles with the modules we use (next steps: sphinx docs?).

Do we really want html_invoice_product_note in the common_accounting_profile? I have in head at least one project which do not use it on purpose.
The profiles should install what is strictly required (in our vision ;-) and this module does not apply IMO (it changes product_template.description from a text to a HTML field which can bring complications, especially when dealing with external systems).

Apart that, seems good to me.

Thanks!

review: Needs Information

« Back to merge proposal