Merge lp:~camptocamp/c2c-addons/accounting-profiles into lp:c2c-addons

[Vincent Renaville@camptocamp]

Hello,

This proposal purpose is to add profile for setup accounting in l10n_ch & l10n_fr

Vincent

[Frederic Clementi - Camptocamp (frederic-clementi)]

LGTM

review: Approve (functional)

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Totally agree with your idea of creating profiles with the modules we use (next steps: sphinx docs?).

Do we really want html_invoice_product_note in the common_accounting_profile? I have in head at least one project which do not use it on purpose.
The profiles should install what is strictly required (in our vision ;-) and this module does not apply IMO (it changes product_template.description from a text to a HTML field which can bring complications, especially when dealing with external systems).

Apart that, seems good to me.

Thanks!

review: Needs Information

[Frederic Clementi - Camptocamp (frederic-clementi)]

easy... just uninstall it, Guewen :)

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

> easy... just uninstall it, Guewen :)

You see the profiles as a script to install a set of modules: we have oerpscenario for that.

In my sense, a profile gathers a set of modules that must be there to accomplish a (large) task and *shouldn't be removed*. If I install common_accounting_profile and then uninstall html_invoice_product_note, common_accounting_profile will be uninstalled as well and then we lose all the benefits of using a profile.

[lp:~camptocamp/c2c-addons/accounting-profiles]

4. By Vincent Renaville@camptocamp on 2014-02-21

[ADD] transaction modules

5. By Vincent Renaville@camptocamp on 2014-03-28

[FIX] remove module html_invoice_product_note depedencie

[Vincent Renaville@camptocamp (vrenaville-c2c)]

Hello Guewen,

I have just remove html_invoice_product_note according to your review at rev 5

Thanks for your review and sorry for the delay

Vincent

[Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c)]

LGTM

review: Approve (code review, no test)

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Thanks

review: Approve

=== added directory 'common_accounting_profile'
=== added file 'common_accounting_profile/__init__.py'
=== added file 'common_accounting_profile/__openerp__.py'
--- common_accounting_profile/__openerp__.py	1970-01-01 00:00:00 +0000
+++ common_accounting_profile/__openerp__.py	2014-03-28 10:26:37 +0000
@@ -0,0 +1,59 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    Author Vincent Renaville. Copyright 2013 Camptocamp SA
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+{
+        "name" : "Common accounting profile",
+        "description" : """Install all modules required for common accounting
+        """,
+        "version" : "1.0",
+        "author" : "Camptocamp",
+        "category" : "Accounting & Finance",
+        "website": "http://www.camptocamp.com",
+        "depends" : [
+            'account_accountant',
+            'account_constraints',
+            'account_default_draft_move',
+            'account_draft_invoice_print',
+            'account_financial_report_webkit',
+            'account_financial_report_webkit_xls',
+            'account_journal_report_xls',
+            'account_move_line_report_xls',
+            'report_xls',
+            'account_export_csv',
+            'account_reversal',
+            'currency_rate_update',
+            'invoice_webkit',
+            'account_compute_tax_amount',
+            'base_iban',
+            'account_move_validation_improvement',
+            'account_statement_base_completion',
+            'account_statement_base_import',
+            'account_statement_ext',
+            'account_statement_commission',
+            'invoicing_voucher_killer',
+            'statement_voucher_killer',
+            'account_advanced_reconcile',
+                    ],
+        "data" :[
+                        ],
+        "active": False,
+        "installable": True
+}
+
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:

=== added directory 'l10n_ch_profile'
=== added file 'l10n_ch_profile/__init__.py'
=== added file 'l10n_ch_profile/__openerp__.py'
--- l10n_ch_profile/__openerp__.py	1970-01-01 00:00:00 +0000
+++ l10n_ch_profile/__openerp__.py	2014-03-28 10:26:37 +0000
@@ -0,0 +1,48 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    Author Vincent Renaville. Copyright 2013 Camptocamp SA
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+{
+        "name" : "L10n_ch accounting profile",
+        "description" : """Install all modules required for accounting in Switzerland
+        """,
+        "version" : "1.0",
+        "author" : "Camptocamp",
+        "category" : "Accounting & Finance",
+        "website": "http://www.camptocamp.com",
+        "depends" : [
+            'common_accounting_profile',
+            'l10n_ch',
+            'l10n_ch_bank',
+            'l10n_ch_base_bank',
+            'l10n_ch_dta',
+            'l10n_ch_payment_slip',
+            'l10n_ch_zip',
+            'l10n_multilang',
+            'payment_term_rounding',
+	    'l10n_ch_dta_base_transaction_id',
+	    'l10n_ch_payment_slip_base_transaction_id',
+	    'l10n_ch_payment_slip_account_statement_base_completion'
+                    ],
+        "data" :[
+                        ],
+        "active": False,
+        "installable": True
+}
+
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:

=== added directory 'l10n_fr_profile'
=== added file 'l10n_fr_profile/__init__.py'
=== added file 'l10n_fr_profile/__openerp__.py'
--- l10n_fr_profile/__openerp__.py	1970-01-01 00:00:00 +0000
+++ l10n_fr_profile/__openerp__.py	2014-03-28 10:26:37 +0000
@@ -0,0 +1,40 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    Author Vincent Renaville. Copyright 2013 Camptocamp SA
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+{
+        "name" : "l10n_fr accounting profile",
+        "description" : """Install all modules required for accounting in France
+        """,
+        "version" : "1.0",
+        "author" : "Camptocamp",
+        "category" : "Accounting & Finance",
+        "website": "http://www.camptocamp.com",
+        "depends" : [
+            'common_accounting_profile',
+            'l10n_fr',
+            'l10n_fr_rib',
+            'l10n_fr_siret',
+                    ],
+        "data" :[
+                        ],
+        "active": False,
+        "installable": True
+}
+
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4: