Code review comment for lp:~camptocamp/account-invoicing/7.0-account_invoice_zero

Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

> Hello,
>
> Juste question at line 109
>
> I don't know if it's better to use float_compare method with precision
>
> prec = self.pool.get('decimal.precision').precision_get(cr, uid, 'Account')
> not float_compare(debit, credit, precision_digits=prec)
>
> Vincent

Thanks for the review. I made the change, but used float_is_zero.

« Back to merge proposal