Merge lp:~camptocamp/account-invoicing/7.0-account_invoice_zero into lp:~account-core-editors/account-invoicing/7.0

[Guewen Baconnier @ Camptocamp]

add account_invoice_zero: automatically set invoices with a zero amount to 'paid'

Invoices with a amount of 0 are automatically set as paid.

When an invoice has an amount of 0, OpenERP still generates a
receivable/payable move line with a 0 balance. The invoice stays as
open even if there is nothing to pay. The user has 2 ways to set the
invoice as paid: create a payment of 0 and reconcile the line with the
payment or reconcile the receivable/payable move line with itself.
This module takes the latter approach and will directly set the invoice
as paid once it is opened.

[Vincent Renaville@camptocamp (vrenaville-c2c)]

Hello,

Juste question at line 109

I don't know if it's better to use float_compare method with precision

prec = self.pool.get('decimal.precision').precision_get(cr, uid, 'Account')
not float_compare(debit, credit, precision_digits=prec)

Vincent

review: Needs Information

[lp:~camptocamp/account-invoicing/7.0-account_invoice_zero]

42. By Guewen Baconnier @ Camptocamp on 2014-03-10

use float comparisons

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

> Hello,
>
> Juste question at line 109
>
> I don't know if it's better to use float_compare method with precision
>
> prec = self.pool.get('decimal.precision').precision_get(cr, uid, 'Account')
> not float_compare(debit, credit, precision_digits=prec)
>
> Vincent

Thanks for the review. I made the change, but used float_is_zero.

[Pedro Manuel Baeza (pedro.baeza)]

Hi, Guewen, I'm curious about the use case for having 0 amount invoices.

review: Needs Information

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

Pedro,

This can be the case when a customer order a product and has a reduction that makes it at 0.

The Sale Order will generate an invoice even if the price is 0.

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

LGTM

review: Approve (code review)

[Vincent Renaville@camptocamp (vrenaville-c2c)]

LGTM

review: Approve

[Pedro Manuel Baeza (pedro.baeza)]

Hi, Guewen, thanks for the clarification. Here in Spain that operation is forbidden by law (because you need at least declare taxes for the amount).

Regards.

review: Approve (code review)

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

> Hi, Guewen, thanks for the clarification. Here in Spain that operation is
> forbidden by law (because you need at least declare taxes for the amount).
>
> Regards.

Interesting.

For my curiosity, if you have a sale line with 100€ taxes included and you add a second line with a rebate of -100€ taxes include too what happens? Can't happen so?

Here, the total amount is 0, the invoice still have move lines for the taxes but they are balanced by the rebate.

Example: ("TVA" are the taxes, "Bons de rabais" are discounts)
http://postimg.org/image/95bb6lgl1/
http://postimg.org/image/95bb6lgl1/

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Twice the same image, here is the second one with the move details.
http://postimg.org/image/k9bx94w17/

[Pedro Manuel Baeza (pedro.baeza)]

Hi, Guewen, the case you told it's also forbidden. Let me explain: the only official mechanism for compensating invoices is via refunds. You don't need to make cash flows, but you need to have both documents. That is theoretically. In practice, if you have an amount to compensate (a potential refund) that is lower than the amount of the invoice, it's a common and tolerated practise to discount it from the invoice, but never if the amount is equal.

I hope I explain it well.

Regards.

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

On 03/14/2014 11:06 AM, Pedro Manuel Baeza wrote:
> Hi, Guewen, the case you told it's also forbidden. Let me explain: the only official mechanism for compensating invoices is via refunds. You don't need to make cash flows, but you need to have both documents. That is theoretically. In practice, if you have an amount to compensate (a potential refund) that is lower than the amount of the invoice, it's a common and tolerated practise to discount it from the invoice, but never if the amount is equal.
>
> I hope I explain it well.
>
> Regards.
>

Good to know!
Thanks for the explanation.

=== added directory 'account_invoice_zero'
=== added file 'account_invoice_zero/__init__.py'
--- account_invoice_zero/__init__.py	1970-01-01 00:00:00 +0000
+++ account_invoice_zero/__init__.py	2014-03-10 14:45:38 +0000
@@ -0,0 +1,3 @@
+# -*- coding: utf-8 -*-
+
+from . import account_invoice

=== added file 'account_invoice_zero/__openerp__.py'
--- account_invoice_zero/__openerp__.py	1970-01-01 00:00:00 +0000
+++ account_invoice_zero/__openerp__.py	2014-03-10 14:45:38 +0000
@@ -0,0 +1,52 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    Author: Guewen Baconnier
+#    Copyright 2014 Camptocamp SA
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+{'name': 'Account Invoice Zero',
+ 'version': '1.0',
+ 'author': 'Camptocamp',
+ 'maintainer': 'Camptocamp',
+ 'license': 'AGPL-3',
+ 'category': 'Accounting & Finance',
+ 'depends': ['account',
+             ],
+ 'description': """
+Account Invoice Zero
+====================
+
+Invoices with a amount of 0 are automatically set as paid.
+
+When an invoice has an amount of 0, OpenERP still generates a
+receivable/payable move line with a 0 balance.  The invoice stays as
+open even if there is nothing to pay.  The user has 2 ways to set the
+invoice as paid: create a payment of 0 and reconcile the line with the
+payment or reconcile the receivable/payable move line with itself.
+This module takes the latter approach and will directly set the invoice
+as paid once it is opened.
+
+ """,
+ 'website': 'http://www.camptocamp.com',
+ 'data': [],
+ 'test': ['test/account_invoice_zero_paid.yml',
+          'test/account_invoice_no_zero_open.yml',
+          ],
+ 'installable': True,
+ 'auto_install': False,
+}

=== added file 'account_invoice_zero/account_invoice.py'
--- account_invoice_zero/account_invoice.py	1970-01-01 00:00:00 +0000
+++ account_invoice_zero/account_invoice.py	2014-03-10 14:45:38 +0000
@@ -0,0 +1,50 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    Author: Guewen Baconnier
+#    Copyright 2014 Camptocamp SA
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+from functools import partial
+
+from openerp.osv import orm
+from openerp.tools.float_utils import float_is_zero
+
+
+class account_invoice(orm.Model):
+    _inherit = 'account.invoice'
+
+    def invoice_validate(self, cr, uid, ids, context=None):
+        result = super(account_invoice, self).invoice_validate(
+            cr, uid, ids, context=context)
+        dp_obj = self.pool['decimal.precision']
+        precision = dp_obj.precision_get(cr, uid, 'Account')
+        is_zero = partial(float_is_zero, precision_digits=precision)
+        for invoice in self.browse(cr, uid, ids, context=context):
+            if is_zero(invoice.amount_total):
+                account = invoice.account_id.id
+                # search the payable / receivable lines
+                lines = [line for line in invoice.move_id.line_id
+                         if line.account_id.id == account]
+                # reconcile the lines with a zero balance
+                if is_zero(sum(line.debit - line.credit for line in lines)):
+                    move_line_obj = self.pool['account.move.line']
+                    move_line_obj.reconcile(cr, uid,
+                                            [line.id for line in lines],
+                                            context=context)
+        return result
+

=== added directory 'account_invoice_zero/test'
=== added file 'account_invoice_zero/test/account_invoice_no_zero_open.yml'
--- account_invoice_zero/test/account_invoice_no_zero_open.yml	1970-01-01 00:00:00 +0000
+++ account_invoice_zero/test/account_invoice_no_zero_open.yml	2014-03-10 14:45:38 +0000
@@ -0,0 +1,40 @@
+-
+  In order to test that the invoices with an amount still behave normally, I create on invoice
+-
+  !record {model: account.invoice, id: account_invoice_state}:
+    account_id: account.a_recv
+    company_id: base.main_company
+    currency_id: base.EUR
+    invoice_line:
+      - account_id: account.a_sale
+        name: '[PCSC234] PC Assemble SC234'
+        price_unit: 450.0
+        quantity: 1.0
+        product_id: product.product_product_3
+        uos_id: product.product_uom_unit
+    journal_id: account.bank_journal
+    partner_id: base.res_partner_12
+    reference_type: none
+-
+  I check that Initially customer invoice state is "Draft"
+-
+  !assert {model: account.invoice, id: account_invoice_state}:
+    - state == 'draft'
+-
+  I called the "Confirm Draft Invoices" wizard
+-
+  !record {model: account.invoice.confirm, id: account_invoice_confirm_0}:
+    {}
+-
+  I clicked on Confirm Invoices Button
+-
+  !python {model: account.invoice.confirm}: |
+    self.invoice_confirm(cr, uid, [ref("account_invoice_confirm_0")], {"lang": 'en_US',
+      "tz": False, "active_model": "account.invoice", "active_ids": [ref("account_invoice_state")],
+      "type": "out_invoice", "active_id": ref("account_invoice_state"), })
+-
+  I check that customer invoice state is "Open"
+-
+  !assert {model: account.invoice, id: account_invoice_state}:
+    - state == 'open'
+

=== added file 'account_invoice_zero/test/account_invoice_zero_paid.yml'
--- account_invoice_zero/test/account_invoice_zero_paid.yml	1970-01-01 00:00:00 +0000
+++ account_invoice_zero/test/account_invoice_zero_paid.yml	2014-03-10 14:45:38 +0000
@@ -0,0 +1,44 @@
+-
+  In order to test that an invoice with a zero amount is directly paid, I create an invoice
+-
+  !record {model: account.invoice, id: account_invoice_zero_paid}:
+    account_id: account.a_recv
+    company_id: base.main_company
+    currency_id: base.EUR
+    invoice_line:
+      - account_id: account.a_sale
+        name: '[PCSC234] PC Assemble SC234'
+        price_unit: 120.0
+        quantity: 1.0
+        product_id: product.product_product_3
+        uos_id: product.product_uom_unit
+      - account_id: account.a_sale
+        name: discount
+        price_unit: -120.0
+        quantity: 1.0
+        uos_id: product.product_uom_unit
+    journal_id: account.bank_journal
+    partner_id: base.res_partner_12
+    reference_type: none
+-
+  I check that Initially customer invoice state is "Draft"
+-
+  !assert {model: account.invoice, id: account_invoice_zero_paid}:
+    - state == 'draft'
+-
+  I called the "Confirm Draft Invoices" wizard
+-
+  !record {model: account.invoice.confirm, id: account_invoice_confirm_0}:
+    {}
+-
+  I clicked on Confirm Invoices Button
+-
+  !python {model: account.invoice.confirm}: |
+    self.invoice_confirm(cr, uid, [ref("account_invoice_confirm_0")], {"lang": 'en_US',
+      "tz": False, "active_model": "account.invoice", "active_ids": [ref("account_invoice_zero_paid")],
+      "type": "out_invoice", "active_id": ref("account_invoice_zero_paid"), })
+-
+  I check that customer invoice state is "Paid"
+-
+  !assert {model: account.invoice, id: account_invoice_zero_paid}:
+    - state == 'paid'