Merge lp:~camptocamp/account-financial-tools/7.0_override_menu_for_search_improvement_mdh into lp:~account-core-editors/account-financial-tools/7.0

Proposed by Matthieu Dietrich @ camptocamp
Status: Rejected
Rejected by: Nicolas Bessi - Camptocamp
Proposed branch: lp:~camptocamp/account-financial-tools/7.0_override_menu_for_search_improvement_mdh
Merge into: lp:~account-core-editors/account-financial-tools/7.0
Diff against target: 45 lines (+24/-2)
2 files modified
account_move_line_search_extension/account_view.xml (+2/-2)
account_move_line_search_extension/i18n/fr.po (+22/-0)
To merge this branch: bzr merge lp:~camptocamp/account-financial-tools/7.0_override_menu_for_search_improvement_mdh
Reviewer Review Type Date Requested Status
Vincent Renaville@camptocamp (community) Approve
Frederic Clementi - Camptocamp (community) fonctional Approve
Luc De Meyer (Noviat) Pending
Review via email: mp+224847@code.launchpad.net

Commit message

[IMP] override default menu for Journal Items

Description of the change

This change is to actually override the existing "Journal Items" menu item with the new one introduced in account_move_line_search_extension, given than the "old one" is not used anymore when the extension is installed.

To post a comment you must log in.
Revision history for this message
Frederic Clementi - Camptocamp (frederic-clementi) wrote :

LGTM

review: Approve (fonctional)
Revision history for this message
Vincent Renaville@camptocamp (vrenaville-c2c) wrote :

LGTM

review: Approve
Revision history for this message
Nicolas Bessi - Camptocamp (nbessi-c2c-deactivatedaccount) wrote :

The project has moved to Github https://github.com/OCA/account-financial-tools.
Please resubmit your MP on github using following procedure https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub.

I put this MP in rejected in the meanwhile.

Regards

Revision history for this message
Luc De Meyer (Noviat) (luc-demeyer) wrote :

I am not sure if override is a good idea.
I made a separate 'Journal Items Search All' entry since the 'fast' encoding of account move lines is a bit easier with the standard Journal Items list view (the journal and period are in that case taken from the values in the 'Period' and 'Journal' selection boxes.
We don't recommend this technique to our customer since it's unpractical and not at all 'fast' (unfortunately the only real 'fast' encoding of accounting entries in OpenERP is via import from xls/csv) but I can imagine that there are people using it, hence a separate entry preserves this encoding mechanism.

Regards,
Luc

www.noviat.com
Rusatiralaan 1, 1083 Brussel
+32 2 808 86 38

-----Original Message-----
From: <email address hidden> [mailto:<email address hidden>] On Behalf Of Frederic Clementi - Camptocamp
Sent: vrijdag 27 juni 2014 16:53
To: Luc De Meyer (Noviat)
Subject: [Merge] lp:~camptocamp/account-financial-tools/7.0_override_menu_for_search_improvement_mdh into lp:account-financial-tools

You have been requested to review the proposed merge of lp:~camptocamp/account-financial-tools/7.0_override_menu_for_search_improvement_mdh into lp:account-financial-tools.

For more details, see:
https://code.launchpad.net/~camptocamp/account-financial-tools/7.0_override_menu_for_search_improvement_mdh/+merge/224847

This change is to actually override the existing "Journal Items" menu item with the new one introduced in account_move_line_search_extension, given than the "old one" is not used anymore when the extension is installed.

--
https://code.launchpad.net/~camptocamp/account-financial-tools/7.0_override_menu_for_search_improvement_mdh/+merge/224847
You are requested to review the proposed merge of lp:~camptocamp/account-financial-tools/7.0_override_menu_for_search_improvement_mdh into lp:account-financial-tools.

Unmerged revisions

185. By Matthieu Dietrich @ camptocamp on 2014-06-27

[IMP] modify menu item for item search extension

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account_move_line_search_extension/account_view.xml'
2--- account_move_line_search_extension/account_view.xml 2014-03-20 14:54:42 +0000
3+++ account_move_line_search_extension/account_view.xml 2014-06-27 14:20:23 +0000
4@@ -12,11 +12,11 @@
5 <menuitem
6 action="action_account_move_line_search_extension"
7 icon="STOCK_JUSTIFY_FILL"
8- id="menu_account_move_line_search_extension"
9+ id="account.menu_action_account_moves_all"
10 parent="account.menu_finance_entries"
11 sequence="1"
12 groups="account.group_account_user"
13 />
14-
15+
16 </data>
17 </openerp>
18
19=== added directory 'account_move_line_search_extension/i18n'
20=== added file 'account_move_line_search_extension/i18n/fr.po'
21--- account_move_line_search_extension/i18n/fr.po 1970-01-01 00:00:00 +0000
22+++ account_move_line_search_extension/i18n/fr.po 2014-06-27 14:20:23 +0000
23@@ -0,0 +1,22 @@
24+# Translation of OpenERP Server.
25+# This file contains the translation of the following modules:
26+# * account_move_line_search_extension
27+#
28+msgid ""
29+msgstr ""
30+"Project-Id-Version: OpenERP Server 7.0\n"
31+"Report-Msgid-Bugs-To: \n"
32+"POT-Creation-Date: 2014-06-27 13:15+0000\n"
33+"PO-Revision-Date: 2014-06-27 13:15+0000\n"
34+"Last-Translator: <>\n"
35+"Language-Team: \n"
36+"MIME-Version: 1.0\n"
37+"Content-Type: text/plain; charset=UTF-8\n"
38+"Content-Transfer-Encoding: \n"
39+"Plural-Forms: \n"
40+
41+#. module: account_move_line_search_extension
42+#: model:ir.actions.act_window,name:account_move_line_search_extension.action_account_move_line_search_extension
43+#: model:ir.ui.menu,name:account_move_line_search_extension.menu_account_move_line_search_extension
44+msgid "Journal Items Search All"
45+msgstr "Écritures comptables"

Subscribers

People subscribed via source and target branches