Code review comment for lp:~camptocamp/account-financial-tools/7.0_override_menu_for_search_improvement_mdh

Revision history for this message
Luc De Meyer (Noviat) (luc-demeyer) wrote :

I am not sure if override is a good idea.
I made a separate 'Journal Items Search All' entry since the 'fast' encoding of account move lines is a bit easier with the standard Journal Items list view (the journal and period are in that case taken from the values in the 'Period' and 'Journal' selection boxes.
We don't recommend this technique to our customer since it's unpractical and not at all 'fast' (unfortunately the only real 'fast' encoding of accounting entries in OpenERP is via import from xls/csv) but I can imagine that there are people using it, hence a separate entry preserves this encoding mechanism.

Regards,
Luc

www.noviat.com
Rusatiralaan 1, 1083 Brussel
+32 2 808 86 38

-----Original Message-----
From: <email address hidden> [mailto:<email address hidden>] On Behalf Of Frederic Clementi - Camptocamp
Sent: vrijdag 27 juni 2014 16:53
To: Luc De Meyer (Noviat)
Subject: [Merge] lp:~camptocamp/account-financial-tools/7.0_override_menu_for_search_improvement_mdh into lp:account-financial-tools

You have been requested to review the proposed merge of lp:~camptocamp/account-financial-tools/7.0_override_menu_for_search_improvement_mdh into lp:account-financial-tools.

For more details, see:
https://code.launchpad.net/~camptocamp/account-financial-tools/7.0_override_menu_for_search_improvement_mdh/+merge/224847

This change is to actually override the existing "Journal Items" menu item with the new one introduced in account_move_line_search_extension, given than the "old one" is not used anymore when the extension is installed.

--
https://code.launchpad.net/~camptocamp/account-financial-tools/7.0_override_menu_for_search_improvement_mdh/+merge/224847
You are requested to review the proposed merge of lp:~camptocamp/account-financial-tools/7.0_override_menu_for_search_improvement_mdh into lp:account-financial-tools.

« Back to merge proposal