Code review comment for ~bryce/ubuntu/+source/virglrenderer:merge-v1.0.0-1-noble

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

range-diff ok
git range-diff bryce/old/debian..bryce/logical/0.10.4-1ubuntu1 bryce/new/debian..bryce/merge-v1.0.0-1-noble

single delta preserved ok

Debian changes:
only new symbols -> reverse deps? soname was kept. Does qemu need rebuild? Looks like not. I installed qemu-system-gui and ran a quick check, the binaries seem to startup fine without symbols errors. qemu doesn't take so long to rebuild, but I won't request a rebuild test for a devel release.

-Dvenus switched to true, was experimental before, and it was enabled already anyway.

GALLIUM_DRIVER changed from softpipe to llvmpipe. Debian changelog says it's for testing. I don't know what it is, and therefore can't suggest if it's a good or bad move. But since noble is an LTS, we should keep an eye on this.

Release notes for 1.0.0: https://gitlab.freedesktop.org/virgl/virglrenderer/-/releases/1.0.0 look ok.

+1

review: Approve

« Back to merge proposal